Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rendezvous spec #284

Merged
merged 3 commits into from
Nov 13, 2020
Merged

fix: rendezvous spec #284

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35d8ad7
fix: rendezvous spec
vasco-santos Jul 20, 2020
0cf5c06
chore: replace peerInfo by signed peer record
vasco-santos Jul 21, 2020
3753c2f
chore: add link to signed peer record spec
vasco-santos Jul 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion rendezvous/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

Authors: [@vyzo]

Interest Group: [@daviddias], [@whyrusleeping], [@Stebalien], [@jacobheun], [@yusefnapora]
Interest Group: [@daviddias], [@whyrusleeping], [@Stebalien], [@jacobheun], [@yusefnapora], [@vasco-santos]
vasco-santos marked this conversation as resolved.
Show resolved Hide resolved

[@vyzo]: https://github.com/vyzo
[@daviddias]: https://github.com/daviddias
Expand Down Expand Up @@ -204,6 +204,7 @@ message Message {
optional string ns = 1;
optional PeerInfo peer = 2;
optional int64 ttl = 3; // in seconds
optional bytes signedPeerRecord = 4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, drop PeerInfo for signedPeerRecord. Also, this spec needs to point to the SignedPeerRecord spec to clarify what bytes signedPeerRecord actually is.

Copy link
Member Author

@vasco-santos vasco-santos Jul 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, should we get the latest recommendations in and get the signed peer record PR merged? #217

}

message RegisterResponse {
Expand Down