Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser <-> Browser over webrtc-private-to-private #152

Closed
wants to merge 8 commits into from

Conversation

MarcoPolo
Copy link
Contributor

Adds browser to browser test. Mostly straightforward except that it requires adding a relay node to the test environment for this case. I'm using relayv1 as the first pass and will move this to relay v2 when we have it in a released version of js-libp2p.

Draft until libp2p/js-libp2p-webrtc#90 is merged

@MarcoPolo
Copy link
Contributor Author

  • add firefox and webkit browser tests here.

@BigLep
Copy link
Contributor

BigLep commented May 5, 2023

@MarcoPolo : agreed that we want Webkit and Firefox, but if there are snags with them, can we at least proceed with Chromium first? If we just focus on Chromium to start (more than the majority of browser usage), can this be moved out of draft?

@MarcoPolo
Copy link
Contributor Author

I think we should merge libp2p/js-libp2p#1615 first as a lot of interfaces changed here.

@BigLep
Copy link
Contributor

BigLep commented May 26, 2023

Unblocked I assume now that libp2p/js-libp2p#1615 is merged?!

@MarcoPolo
Copy link
Contributor Author

This is unblocked now :)

@MarcoPolo
Copy link
Contributor Author

I'm going to get this back up to speed using the latest stuff from js-libp2p. I think I can simplify some things in this PR as well.

@MarcoPolo
Copy link
Contributor Author

This is done now. Closing this pr

@MarcoPolo MarcoPolo closed this Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants