Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing API endpoints #6

Open
54 of 59 tasks
benediktwerner opened this issue May 8, 2023 · 28 comments
Open
54 of 59 tasks

Implement missing API endpoints #6

benediktwerner opened this issue May 8, 2023 · 28 comments
Labels
good first issue Good for newcomers

Comments

@benediktwerner
Copy link
Member

benediktwerner commented May 8, 2023

The list below shows API endpoints that are currently still missing from berserk (generated by the check-endpoints.py script).

Feel free to choose any one and implement it.

See https://github.com/lichess-org/berserk/tree/master/berserk/clients for existing endpoint implementations.

New endpoints should have their responses typed. See https://github.com/lichess-org/berserk/blob/master/berserk/clients/opening_explorer.py/#L35 for an example of how to type dictionary responses.

For more info on the details of any specific endpoint, see https://lichess.org/api.

Also see the Get Started contributing section.

@benediktwerner benediktwerner added the good first issue Good for newcomers label May 8, 2023
@benediktwerner benediktwerner changed the title Implement missing endpoints Implement missing API endpoints May 8, 2023
@kraktus kraktus pinned this issue May 8, 2023
@Virinas-code

This comment was marked as outdated.

@AKBuggy

This comment was marked as outdated.

@Virinas-code

This comment was marked as outdated.

@Virinas-code

This comment was marked as outdated.

@AKBuggy

This comment was marked as outdated.

kraktus added a commit that referenced this issue May 21, 2023
fix #16

Also resolves the endpoint for #6
@thegrapesoda

This comment was marked as outdated.

@Virinas-code

This comment was marked as outdated.

@Virinas-code

This comment was marked as outdated.

@benediktwerner

This comment was marked as outdated.

@Virinas-code

This comment was marked as outdated.

@Virinas-code

This comment was marked as outdated.

@Virinas-code Virinas-code mentioned this issue Jun 16, 2023
3 tasks
@skanjalkar
Copy link
Contributor

Hi,

I opened a PR #30 addressing some of these.

@shaikhmudassir

This comment was marked as outdated.

@benediktwerner

This comment was marked as outdated.

@rpesche

This comment was marked as outdated.

@Virinas-code

This comment was marked as outdated.

@Virinas-code

This comment was marked as outdated.

@benediktwerner

This comment was marked as outdated.

@Anupya

This comment was marked as outdated.

@kraktus

This comment was marked as outdated.

@jacksonthall22

This comment was marked as outdated.

@benediktwerner

This comment was marked as outdated.

@rdev99
Copy link

rdev99 commented Mar 16, 2024

Is this issue still open ?

If its open, how much api's are left

@kraktus
Copy link
Member

kraktus commented Mar 17, 2024

Is this issue still open ?

If its open, how much api's are left

Hey, yes the endpoints not ticked are left to grab .

@rdev99
Copy link

rdev99 commented Mar 18, 2024

Thanks, I will work on it if anyone else is not working

@kraktus
Copy link
Member

kraktus commented Mar 18, 2024

Cool, if you want to implement external-engine endpoints, make sure to check feedback given in #66 before

@rdev99
Copy link

rdev99 commented Mar 18, 2024

Hey,

I think these api's are already completed in the code but not ticked here.

https://explorer.lichess.ovh/master/pgn/{gameId}
https://explorer.lichess.ovh/masters

Also what is to be confirmed in https://explorer.lichess.ovh/lichess/history

@FriedrichtenHagen
Copy link

@kraktus I opened a pr that implements the advice given in #66. Could you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests