Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bulk pairing client (#6) and rework account client #43

Merged
merged 9 commits into from
Sep 2, 2023
Merged

Add bulk pairing client (#6) and rework account client #43

merged 9 commits into from
Sep 2, 2023

Conversation

Virinas-code
Copy link
Contributor

@Virinas-code Virinas-code commented Aug 16, 2023 •
edited
Loading

Implements the following endpoints (#6):

  • /api/bulk-pairing
  • /api/bulk-pairing/{id}
  • /api/bulk-pairing/{id}/start-clocks

ℹ️ NOTE: No tests where added since you would need an API token.

All the endpoints are typed.

@Virinas-code Virinas-code mentioned this pull request Aug 16, 2023
Open
59 tasks
@Virinas-code Virinas-code changed the title Add bulk pairing client (#6) Add bulk pairing client (#6) and rework account client Aug 21, 2023
kraktus
kraktus reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@kraktus kraktus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Overhaul looks great, left a few comments, I can address them myself when I've time (few days) if you prefer.

Also type check test are currently failing.

CHANGELOG.rst Outdated Show resolved Hide resolved
berserk/clients/account.py Outdated Show resolved Hide resolved
berserk/clients/bulk_pairings.py Outdated Show resolved Hide resolved
berserk/types/core/aliases.py Outdated Show resolved Hide resolved
berserk/clients/bulk_pairings.py Outdated Show resolved Hide resolved
berserk/types/account.py Outdated Show resolved Hide resolved
berserk/types/account.py Outdated Show resolved Hide resolved
@benediktwerner benediktwerner merged commit 54c4450 into lichess-org:master Sep 2, 2023
16 checks passed
@Virinas-code
Copy link
Contributor Author

Sorry for not being active, I was working on other projects 😅 Will rework enums one day (maybe even today) when I have the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraktus kraktus kraktus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Virinas-code @kraktus @benediktwerner