Option for public mods to display icon in forum/qa #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes lichess-org#754. Closes lichess-org#1092. Partial lichess-org#931. This is possible for forum posts (also the first post of a topic) and Q&A answers (not questions, because that doesn't seem useful at all). Above the 'Submit' button, there is a checkbox to tell if you want to display a moderator icon next to your name. If a non-PublicMod tries to add this checkbox himself, the `modIcon` Option[Boolean] is still set to None and no icon will appear.
ornicar
reviewed
Jul 9, 2017
modules/forum/src/main/PostApi.scala
Outdated
| @@ -41,7 +41,8 @@ final class PostApi( | |||
| lang = lang map (_.language), | |||
| troll = ctx.troll, | |||
| hidden = topic.hidden, | |||
| categId = categ.id | |||
| categId = categ.id, | |||
| modIcon = (data.modIcon.getOrElse(false) && ctx.me.map(MasterGranter(_.PublicMod)).getOrElse(false)).fold(Some(true), None) | |||
There was a problem hiding this comment.
booleanOption.getOrElse(false) == ~booleanOption (twice)
.fold(Some(a), None) == .option(a)
ornicar
reviewed
Jul 9, 2017
modules/qa/src/main/QaApi.scala
Outdated
| @@ -161,7 +162,7 @@ final class QaApi( | |||
| private implicit val voteBSONHandler = Macros.handler[Vote] | |||
| private implicit val answerBSONHandler = Macros.handler[Answer] | |||
|
|
|||
| def create(data: AnswerData, q: Question, user: User): Fu[Answer] = | |||
| def create(data: AnswerData, q: Question, user: User)(implicit ctx: UserContext): Fu[Answer] = | |||
There was a problem hiding this comment.
Is the context needed here? We already have the user who posts the answer.
|
all fixed @ornicar |
|
it's on stage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #754. Closes #1092. Partial #931.
This is possible for forum posts (also the first post of a topic) and Q&A
answers (not questions, because that doesn't seem useful at all).
Above the 'Submit' button, there is a checkbox to tell if you want to
display a moderator icon next to your name.
If a non-PublicMod tries to add this checkbox himself, the
modIconOption[Boolean] is still set to None and no icon will appear.