Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: react 19 support #125

Merged
merged 5 commits into from
Jan 23, 2025
Merged

feat: react 19 support #125

merged 5 commits into from
Jan 23, 2025

Conversation

lifeiscontent
Copy link
Owner

@lifeiscontent lifeiscontent commented Jan 23, 2025

📦 Published PR as canary version: 8.0.0--canary.125.a976788.0

✨ Test out this PR locally via:

npm install storybook-addon-apollo-client@8.0.0--canary.125.a976788.0
# or 
yarn add storybook-addon-apollo-client@8.0.0--canary.125.a976788.0

lifeiscontent and others added 3 commits January 23, 2025 01:35
- Storybook is still using the older React runtime instead of jsx-runtime, so React is globalized to avoid duplication, only if we don't use jsx-runtime. Tsup respects the configuration from tsconfig.json so it is now changed.
- @storybook core dependencies are now moved to storybook/internal/*
- React shouldn't be prebundled by tsup so it's now moved to a peer dep instead
- Some dependencies are removed as they are not needed anymore
- The demo Storybook now shows some docs
@lifeiscontent lifeiscontent self-assigned this Jan 23, 2025
@lifeiscontent lifeiscontent added the major Increment the major version when merged label Jan 23, 2025
@lifeiscontent lifeiscontent marked this pull request as ready for review January 23, 2025 11:34
@lifeiscontent lifeiscontent merged commit 8ea7d0d into main Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Increment the major version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants