This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
feat!: add import-extensions rule #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I originally created the issue, I was thinking about ".soy.js" imports, but in the end we may as well apply it to all ".js" imports. See the documentation in this commit for details on why this is a reasonable approach for our codebases, and why I think we won't need any configurability at this time. Closes: #137
|
Output of test run in liferay-portal: https://gist.github.com/wincent/0f98a543fb7b67b2d82666af8b144830 Corresponding autofixes: https://gist.github.com/wincent/96671dc346caa79b4e8f956ddb1a7b89 Which is to say, all looks good and I think this can be merged once CI is green. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I originally created the issue, I was thinking about ".soy.js" imports, but in the end we may as well apply it to all ".js" imports. See the documentation in this commit for details on why this is a reasonable approach for our codebases, and why I think we won't need any configurability at this time.
Closes: #137