Merge pull request #1143 from bryceosterhaus/LPS-186142

fix(npm-scripts): wipe the tsbuildinfo file to ensure consistent types
liferay · Jun 20, 2023 · ca5e7a0 · ca5e7a0
2 parents 011a5ec + 6d892a7
commit ca5e7a0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/projects/npm-tools/packages/npm-scripts/src/scripts/types.js b/projects/npm-tools/packages/npm-scripts/src/scripts/types.js
@@ -3,7 +3,6 @@
  * SPDX-License-Identifier: BSD-3-Clause
  */
 
-const fs = require('fs');
 const path = require('path');
 
 const getTypeScriptBuildOrder = require('../typescript/getTypeScriptBuildOrder');
@@ -42,18 +41,6 @@ async function types() {
 		try {
 			process.chdir(directory);
 
-			const buildInfoPath = path.join(
-				process.cwd(),
-				'tmp',
-				'tsconfig.tsbuildinfo'
-			);
-
-			// Remove previous type information to ensure a consistent build
-
-			if (fs.existsSync(buildInfoPath)) {
-				fs.unlinkSync(buildInfoPath);
-			}
-
 			const config = getMergedConfig('npmscripts');
 
 			const {build: BUILD_CONFIG} = config;

diff --git a/projects/npm-tools/packages/npm-scripts/src/typescript/runTSC.js b/projects/npm-tools/packages/npm-scripts/src/typescript/runTSC.js
@@ -33,6 +33,18 @@ async function runTSC() {
 
 	const config = configureTypeScript(graph);
 
+	const buildInfoPath = path.join(
+		process.cwd(),
+		'tmp',
+		'tsconfig.tsbuildinfo'
+	);
+
+	// Remove previous type information to ensure a consistent build
+
+	if (fs.existsSync(buildInfoPath)) {
+		fs.unlinkSync(buildInfoPath);
+	}
+
 	spawnSync('tsc', ['--emitDeclarationOnly']);
 
 	// Format the generated files, because: https://git.io/JYNZp