Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm-scripts): wipe the tsbuildinfo file to ensure consistent types #1143

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

bryceosterhaus
Copy link
Member

@bryceosterhaus bryceosterhaus commented Jun 19, 2023

I think this should help resolve our issues of getting inconsistent .d.ts files with /// <reference .... We originally added this logic to just the yarn types command and it helped out quite a bit, but now we also need it on individual module builds, so I am removing the file everytime we run runTsc.

I can't totally figure out why we are getting odd behavior with those references in d.ts files, but I suspect it may be
a bug in our TS version. I ran some tests with TS on the latest version and I wasn't able to reproduce this issue,
although it brought other issues.

Now I'm not totally stoked with this because this may increase our build time a little bit, although not significantly
because we have our own npm-scripts cacheing mechanism. So I think we stick with this for now and then investigate
upgrading to TS 5 later.

@bryceosterhaus
Copy link
Member Author

improvements after this issue will be done in https://liferay.atlassian.net/browse/LPS-188133

@bryceosterhaus bryceosterhaus merged commit ca5e7a0 into liferay:master Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant