Upgraded jBCrypt to v0.4 #1942
Merged
Upgraded jBCrypt to v0.4 #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadowfiend
previously approved these changes
Mar 1, 2018
farmdawgnation
requested changes
Mar 3, 2018
There was a problem hiding this comment.
This is removing a public API in the net.liftweb namespace. I'm 200% for removing net.liftweb.util.BCrypt, but we should reimplement it as a proxy for the actual BCrypt implementation until 4.0, mark all the public methods as deprecated, and then actually remove it in 4.0. :/
|
|
Shadowfiend
dismissed
their stale review
Whoops, let's not approve dropping a public API 🙊
We can't nuke that BCrypt class as it is public API in the net.liftweb.util package. We introduce a deprecated class that passes through both docs and public methods calls to org.mindrot.jbcrypt.BCrypt.
|
Added #1945 to put the public API back in as a deprecated pass-through. |
Bridges of BCrypt: Reintroduce pass-through deprecated net.liftweb.util.BCrypt
|
💯 merging. We need to coordinate point releases of our various branches, as well. |
1 similar comment
|
💯 merging. We need to coordinate point releases of our various branches, as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1941
I did confirm that the copy we had was the same as the previously published 0.3 version.
I didn't test this against any apps as I'm not using either of the fields anywhere. However, this jar was published 3 years ago, so I think it's probably safe to use.
Lastly, we should probably publish a 2.6.4 version, but I don't see a branch on Github for 2.6 anywhere and wasn't sure how to go about backporting.