Bridges of BCrypt: Reintroduce pass-through deprecated net.liftweb.util.BCrypt #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't nuke that BCrypt class as it is public API in the net.liftweb.util package. We introduce a deprecated class that passes through both docs and public methods calls to org.mindrot.jbcrypt.BCrypt.
| /** | ||
| * @see org.mindrot.jbcrypt.BCrypt#hashpw(String,String) | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
A message explaining the deprecation would probably be a good idea for all of these.
There was a problem hiding this comment.
62.3% sure the Java deprecated annotation supports neither a message nor a version.
There was a problem hiding this comment.
Oh right this is a java file. Sigh.
There was a problem hiding this comment.
ahHA!
this is why i'm seeing
method hashpw in class BCrypt is deprecated: see corresponding Javadoc for more information.
🤦
made me think that hashpw was deprecated up the chain. 😅
farmdawgnation
approved these changes
Mar 3, 2018
eltimn
approved these changes
Mar 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eltimn had a moment to go ahead and do this to hopefully save you the time :)
Merges into #1942 .