Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert protobuf support to TypeScript #294

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

pvlugter
Copy link
Member

@pvlugter pvlugter commented Apr 8, 2022

Refs #293. Breaking up into smaller steps. Only targeting kalix-main for this.

Convert the protobuf any support and tests to TypeScript. Direct translation, just add typing.

@github-actions github-actions bot added kalix-runtime Runtime and SDKs sub-team typescript-sdk labels Apr 8, 2022
@pvlugter pvlugter force-pushed the typescript-protobuf-any branch from 6bae148 to 72c72b7 Compare April 8, 2022 01:31
@pvlugter pvlugter changed the title Convert protobuf support to TypeScript chore: convert protobuf support to TypeScript Apr 8, 2022
@pvlugter pvlugter force-pushed the typescript-protobuf-any branch from 72c72b7 to bca580c Compare April 8, 2022 01:35
Copy link
Contributor

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvlugter pvlugter merged commit 708988d into lightbend:kalix-main Apr 11, 2022
@pvlugter pvlugter deleted the typescript-protobuf-any branch April 11, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kalix-runtime Runtime and SDKs sub-team typescript-sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants