Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert effect serializer to TypeScript #295

Merged

Conversation

pvlugter
Copy link
Member

@pvlugter pvlugter commented Apr 8, 2022

Refs #293. Draft, builds on #294.

Convert effect serializer and test directly over to TypeScript.

@github-actions github-actions bot added kalix-runtime Runtime and SDKs sub-team typescript-sdk labels Apr 8, 2022
@pvlugter pvlugter changed the title Typescript effect serializer chore: convert effect serializer to TypeScript Apr 8, 2022
@pvlugter pvlugter force-pushed the typescript-effect-serializer branch from d2fb6b7 to 0f62f1e Compare April 8, 2022 05:36
@pvlugter pvlugter force-pushed the typescript-effect-serializer branch from 0f62f1e to 9245ec2 Compare April 11, 2022 05:26
@pvlugter pvlugter marked this pull request as ready for review April 11, 2022 05:27
@pvlugter
Copy link
Member Author

Rebased and reviewable now

Copy link
Contributor

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johanandren johanandren merged commit feb49aa into lightbend:kalix-main Apr 13, 2022
@pvlugter pvlugter deleted the typescript-effect-serializer branch April 13, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kalix-runtime Runtime and SDKs sub-team typescript-sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants