fix: compatibility with chrome 51 #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pecoram
commented
Nov 22, 2024
•
pecoram
commented
- added alternative to roundRect it not supported
- added WebGlContext error message
pecoram
changed the title
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
Fixes for handling base64 src strings on Chrome v38, rework Image texture fallback & detection. This PR includes: * Using a 1x1 PNG pixel to determine which `createImageBitmap` signature is supported on the browser * Fallback the image worker and main thread `ImageTexture` handling according to the detected signature * Support for base64 `src` on Chrome v38 * Support for `createImageBitmap(blob)` without a config object for Chrome v50 (linked to #454) * Support for ES5 legacy output of the `examples` directory (will be published on https://lightning-js.github.io/renderer/ automatically) * Upgrade `vite` and `vitest` to 2.x devDependencies, pin to TS 5.6.x for now (as 5.7.x has issues with other dependencies) * Upgrade Playwright 1.39 to 1.49 for automated tests * Refactor Visual Regression test pixel matching and snapshot handling by using [pixelmatch](https://www.npmjs.com/package/pixelmatch) and [pngjs](https://www.npmjs.com/package/pngjs) over a homebrew detection + upng (which is stale). * SDF font initialization waits for image support detection before uploading the SDF texture atlas. * Added documentation on the fallback process and references to chrome versions in `BROWSERS.md`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.