-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Chrome v38 #456
Merged
Merged
Fixes for Chrome v38 #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Enable es5 output on examples.
…legacy browser issues
elsassph
reviewed
Nov 25, 2024
elsassph
reviewed
Nov 25, 2024
…eTextureManager and ImageWorker
wouterlucas
requested review from
elsassph and
jfboeve
and removed request for
elsassph
November 25, 2024 22:27
Using a 1x1 binary png pixel to detect if which createImageBitmap to handle chrome v50/51, small detour with eslint and dependencies to upgrade to newer vite legacy for es5 examples. |
pecoram
reviewed
Nov 26, 2024
This fixes an issue where the SDF Font images are being uploaded while the createImageBitmap probing was still ongoing. As a result the image texture uses the lowest available createImageBitmap signature without options. Causing the alpha channel to be ignored which in turn results into jarred text rendering with SDF due to alignment issues.
fix code blocks
jfboeve
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for handling base64 src strings on Chrome v38, rework Image texture fallback & detection.
This PR includes:
createImageBitmap
signature is supported on the browserImageTexture
handling according to the detected signaturesrc
on Chrome v38createImageBitmap(blob)
without a config object for Chrome v50 (linked to fix: compatibility with chrome 51 #454)examples
directory (will be published on https://lightning-js.github.io/renderer/ automatically)vite
andvitest
to 2.x devDependencies, pin to TS 5.6.x for now (as 5.7.x has issues with other dependencies)BROWSERS.md