Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for InvokeHostFunctionOperation & add Address class. #481

Merged
merged 5 commits into from
Jul 25, 2023

Conversation

overcat
Copy link
Member

@overcat overcat commented Jul 13, 2023

Changelog:

  • Add support for InvokeHostFunctionOperation. (Closes Support for new InvokeHostFunctionOperation #472)
  • Add support for parsing InvokeHostFunctionOperationResponse.
  • Add Address class, it represents a single address in the Stellar network.
  • Updated xdr definitions for Stellar Soroban & fix the issues caused by the XDR update.

Note:

This PR depends on stellar/xdrgen#159, stellar/xdrgen#160 and stellar/xdrgen#161, let's also merge these PRs.

@sreuland
Copy link
Contributor

@overcat , we have an epic, #470 which captures a breakdown of sub-tasks related to soroban support also, it might help to refer to that to help scope these PR's down to one of those tasks at a time. This PR looks pretty aligned with #472 , do you agree?

@overcat
Copy link
Member Author

overcat commented Jul 19, 2023

Hi @sreuland, could you please create a soroban branch from the master branch? This way, I can set the merge target to the soroban branch and make each PR as small as possible.

P.S. Let's merge this PR first and then continue with other tasks.

@overcat overcat changed the title [WIP] Add Soroban support. Add support for InvokeHostFunctionOperation & add Address class. Jul 19, 2023
@overcat overcat marked this pull request as ready for review July 19, 2023 11:00
@sreuland
Copy link
Contributor

@overcat , created soroban branch, thanks!

@overcat overcat changed the base branch from master to soroban July 19, 2023 22:48
@overcat
Copy link
Member Author

overcat commented Jul 19, 2023

@overcat , created soroban branch, thanks!

Thank you, I have changed the branch so this PR is ready to be reviewed.

@overcat overcat force-pushed the soroban branch 2 times, most recently from fd59782 to d6a7b60 Compare July 20, 2023 11:24
@overcat
Copy link
Member Author

overcat commented Jul 20, 2023

Hi, @sreuland and @tamirms, the PR is ready, could you please review and merge it?

@overcat
Copy link
Member Author

overcat commented Jul 21, 2023

Rebased the code to make the commit log more readable, without including any code changes.

@overcat
Copy link
Member Author

overcat commented Jul 21, 2023

If there are no other issues, let's merge this PR so that other PRs can join the queue.

@sreuland
Copy link
Contributor

@overcat , I left review comments with some changes for consideration, overall looks good, based on your feedback on those, we can get this merged when ready. thanks!

@overcat
Copy link
Member Author

overcat commented Jul 22, 2023

@sreuland PTAL

Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@overcat
Copy link
Member Author

overcat commented Jul 24, 2023

Rebased the code to make the commit log more readable, without including any code changes.

@overcat
Copy link
Member Author

overcat commented Jul 24, 2023

Hi @sreuland, PTAL, if there are no other issues, please merge it.

@sreuland
Copy link
Contributor

sreuland commented Jul 24, 2023

Hi @sreuland, PTAL, if there are no other issues, please merge it.

@overcat , does this pr close out #472 ? if so, can you add Closes #472 to the PR's description before we merge, to get tickets to be auto-completed at same time, thanks!

@overcat
Copy link
Member Author

overcat commented Jul 25, 2023

Hi @sreuland, PTAL, if there are no other issues, please merge it.

@overcat , does this pr close out #472 ? if so, can you add Closes #472 to the PR's description before we merge, to get tickets to be auto-completed at same time, thanks!

Added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for new InvokeHostFunctionOperation
3 participants