-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for InvokeHostFunctionOperation & add Address
class.
#481
Add support for InvokeHostFunctionOperation & add Address
class.
#481
Conversation
Hi @sreuland, could you please create a P.S. Let's merge this PR first and then continue with other tasks. |
Address
class.
@overcat , created soroban branch, thanks! |
Thank you, I have changed the branch so this PR is ready to be reviewed. |
fd59782
to
d6a7b60
Compare
Rebased the code to make the commit log more readable, without including any code changes. |
If there are no other issues, let's merge this PR so that other PRs can join the queue. |
src/main/java/org/stellar/sdk/responses/operations/InvokeHostFunctionOperationResponse.java
Show resolved
Hide resolved
src/test/java/org/stellar/sdk/responses/OperationDeserializerTest.java
Outdated
Show resolved
Hide resolved
@overcat , I left review comments with some changes for consideration, overall looks good, based on your feedback on those, we can get this merged when ready. thanks! |
@sreuland PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
Rebased the code to make the commit log more readable, without including any code changes. |
Hi @sreuland, PTAL, if there are no other issues, please merge it. |
Changelog:
Address
class, it represents a single address in the Stellar network.Note:
This PR depends on stellar/xdrgen#159, stellar/xdrgen#160 and stellar/xdrgen#161, let's also merge these PRs.