-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(java): Set the default maximum value for XdrString. #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @tamirms, can you review and merge this PR? |
@overcat could you explain why this PR is necessary? |
I have added the reasons above, please check it. |
overcat
commented
Aug 10, 2023
@@ -39,7 +39,7 @@ public void encode(XdrDataOutputStream stream) throws IOException { | |||
} | |||
public static Str2 decode(XdrDataInputStream stream) throws IOException { | |||
Str2 decodedStr2 = new Str2(); | |||
decodedStr2.str2 = XdrString.decode(stream, ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous code fails to compile.
tamirms
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XDR RFC document states
As an example of testing code, here are the .x file and the generated code. Such code cannot pass compilation.
xdrgen/spec/fixtures/generator/test.x
Line 10 in 48fffac
So we need to set a default maximum value for it. According to the protocol, it should be
(2**32) - 1
, but due to Java's limitations*, we used int to store the maximum value, so we have set it as(2**31) - 1
. I believe this should meet our requirements as in practical business scenarios, the length of strings we use will not exceed this value.Java's limitations:
xdrgen/lib/xdrgen/generators/java/XdrString.erb
Line 30 in 48fffac