refactor: ♻️ refactor component to remove unwanted code #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⏳ Generating Lighthouse report... |
| import { FormikValues } from 'formik'; | ||
| import userEvent from '@testing-library/user-event'; |
There was a problem hiding this comment.
please set the order of imports correctly
| label: string; | ||
| }; | ||
|
|
||
| const FinancialDetailsDropdownField = ({ |
There was a problem hiding this comment.
Should we move this component to the separate file?
There was a problem hiding this comment.
Not needed as that is the only component there. The other is a wrapper
| describe('<FinancialDetails />', () => { | ||
| let mock_props: TFinancialDetails & TFinancialInformationAndTradingExperience = { | ||
| const mock_props: TFinancialDetails = { |
There was a problem hiding this comment.
Let’s not export type for the component, but use it as ComponentProps.
how do you think?
yauheni-deriv
approved these changes
Aug 11, 2023
likhith-deriv
merged commit c14a0f7
into
likhith/WEBREL-795/Refactor-real-account-signup-flow
2 checks passed
likhith-deriv
added a commit
that referenced
this pull request
Oct 5, 2023
* fix: ⚡ refactored Address-details component * fix: 🎨 failing testcases * refactor: ♻️ incorporated review comments * feat: 🔥 removed PlatformContext * fix: testcase failure * refactor: ♻️ incorporated review comments * refactor: ♻️ refactor component to remove unwanted code (#44) * refactor: ♻️ refactor component to remove unwanted code * feat: removed commented code * test: ✅ added testcase * test: 🧪 added tests * refactor: ♻️ incorporated review comments * refactor: ♻️ incorporated review comments * refactor: ♻️ incorporated review comments * refactor: ♻️ migrated code to TS (#45) * refactor: ♻️ migrated code to TS * refactor: ♻️ incorporated review comments * refactor: ♻️ incorporated review comments * Update packages/account/src/Types/common-prop.type.ts Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> --------- Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> * refactor: ⚡ refactored currency selector component (#43) * refactor: ⚡ refactored currency selector component * fix: 🚨 lint errors * feat: incorporated store values * fix: 🎨 split code into small components * fix: 🎨 removed un-necessary array * refactor: ♻️ incorporated review comments * refactor: ♻️ incorporated review comments * resolved failing test cases * chore: incorporated review comment * fix: build issue * fix: build issue * ref: incorporated review comments * refactor: Modified code to contain hooks * refactor: Modified code to contain hooks * replaced test component * fix: eslint issues * fix: failing testcases * ref: Incorporated review somments * Likhith/webrel 780/migrate Email and password section (#7) * chore: migrated deriv-email and unlink component * chore: migrate password-platform to tsx * chore: migrate password-platform to tsx * chore: added missing test cases * ref: incorporated review comments * refactor: incorporated review comments * refactor: incorporated review comments * refactor: incorporated review comments * ref: Incorporated review somments * chore: config files ts migration and refactor (#8) * chore: config files ts migartion and refactor * refactor: test case for config func * fix: config typing * refactor: remove custom accounts residence type * refactor: review comment * chore: added test cases * fix: revert boolean in types * refactor: default value fields * refactor: files types, import react types * refactor: react types * fix: condition rule * fix: failing testcase --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * fix: incorporated review comments * fix: failing testcase * refactor: migrate form-fields file (#10) * refactor: migrate form-fields file * refactor: migrate form-fields file * ref: incorporated review comments * fix: failing testcase * fix: incorporated review comments * fix: incorporated review comments * fix: incorporated review comments * fix: resolved Sonar lint errors * fix: tslint issues * fix: review comments * fix: review comments * refactor: 🎨 incorporated types for test cases * fix: 🦺 incorporated review comments * fix: 🎨 incorporated ui-store-fix * fix: ⚰️ replaced deprecated hooks * fix: 🔥 unused dependency * Merge branch 'master' into KYC-accounts-package-TS-migration--test-coverage/sprint-8 * chore: added package-lock * fix: added value for mock-store --------- Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: Shahzaib <shahzaib@deriv.com>
likhith-deriv
pushed a commit
that referenced
this pull request
Dec 12, 2023
…ctoring (deriv-com#10848) * chore: empty commit * Kate / DTRA-325 / TS migration: Form/TradeParams/Duration files in Trader package (#43) * refactor: ts of expity text * refactor: ts of duration toggle * refactor: ts of simple duration * fix: types * feat: ts of duration wrapper * refactor: ts of daration * refactor: add ts for advanced duration * refactor: ts of duration mobile * refactor: unit test * refactor: apply suggestions * chore: add fallback for simple duration unit * refactor: apply suggestions * chore: refactor type * refactor: remove code smells * Kate / DTRA-421 / TS migration: Contract + ContractReplay in Trader package (#44) * refactor: ts of contract file * refactor: ts of contract replay * refactor: add more types for contract store * chore: expand type * refactor: apply suggestions * refactor: separate replay chart from contract replay * refactor: add ternary rendering * fix: revert latest changes * refactor: remove code smells * Maryia/DTRA-324/refactor: TS migration of trade.jsx and refactoring (#45) * chore: migrate trade to ts * chore: remove unnecessary line * chore: migrate to ts - test and init-store * chore: remove unused test component * chore: more files to ts * chore: add types to trade * chore: trade-chart to ts * refactor: is_mobile * chore: add types to SmartChartSwitcher * chore: ToolbarWidgetsBeta to ts * fix: a type * fix: ws type * chore: remove unused setting * refactor: alphabetical order * chore: index.js to index.ts * refactor: address comments * chore: remove code smells * chore: change type * refactor: apply suggestions * fix: add missing string * refactor: apply suggestions * chore: add math trunc method * chore: remove extra ui mocked prop --------- Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com>
likhith-deriv
pushed a commit
that referenced
this pull request
Jun 12, 2024
…iv-com#15237) * refactor: [UPM-1080]/evgeniy/refactor passkeys code * refactor: tests and code completion * refactor: do not fetch passkeys list, when no need to open the modal * refactor: tests fix, remove btn loader status, icons change * refactor: do not call for passkeys if local storage value is false * chore: added todo for tracking events * refactor: client store remove unnecessary checks, tests, icons * chore: skip changing the state for created status * refactor: removed unnecessary li tag in modal * chore: rename passkey (#44) * chore: rename passkey * chore: test fix * fix: styles for rtl * refactor: call success event only after success renaming * chore: hide disabled dropdown item * chore: review comments * fix: accidentally removed clsx import * chore: snackbar fix, loading while fething new name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.