Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize copyright headers. #2399

Merged
merged 3 commits into from
May 21, 2024
Merged

Standardize copyright headers. #2399

merged 3 commits into from
May 21, 2024

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Feb 23, 2024

The Linebender standard for copyright headers was decided last year in kurbo#207 as the following:

// Copyright <year of file creation> the <Project> Authors
// SPDX-License-Identifier: Apache-2.0 OR MIT

This PR converts all file headers to this standard form. Note that Druid is not dual licensed under MIT and is Apache 2.0 only.

@xStrom xStrom added maintenance cleans up code or docs S-needs-review waits for review labels Feb 23, 2024
@xStrom
Copy link
Member Author

xStrom commented Mar 1, 2024

I also added a copyright header check to CI. It's essentially a copy of the check from vello#463.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really maintain Druid, but I have scanned and confirmed that this only does as mentioned in the PR description

I can't see any plausible downside to doing this, but I think we should get in-principle signoff from @raphlinus

@xStrom xStrom added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 21, 2024
@xStrom xStrom enabled auto-merge May 21, 2024 21:19
@xStrom xStrom added this pull request to the merge queue May 21, 2024
Merged via the queue into linebender:master with commit 4fe3939 May 21, 2024
12 checks passed
@xStrom xStrom deleted the copyhead branch May 21, 2024 21:24
@xStrom xStrom removed the S-needs-review waits for review label May 21, 2024
@xStrom xStrom added this to the Release 0.9 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance cleans up code or docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants