Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous license #207

Closed
mwcampbell opened this issue Dec 18, 2021 · 7 comments · Fixed by #245
Closed

Ambiguous license #207

mwcampbell opened this issue Dec 18, 2021 · 7 comments · Fixed by #245
Labels
needs discussion This change requires some more discussion before we decide we definitely want it

Comments

@mwcampbell
Copy link
Contributor

The top level of the repository has files for both the MIT and Apache licenses, suggesting dual licensing. But src/lib.rs indicates only the Apache license. I would prefer dual licensing, since I can't use any dependency that's solely under the Apache license in the core of AccessKit.

@raphlinus
Copy link
Contributor

It is dual MIT + Apache, and I agree that the notice in the source files is unclear. I would happily accept a PR that clarified the license strings in the files. I think one good model for this might be the newer files in piet-gpu, for example stages.rs.

@derekdreery
Copy link
Collaborator

Does having the license text at the top of each file make a difference legally? If not I think it's better to only include it in lib.rs.

@derekdreery
Copy link
Collaborator

I propose changing the preamble in lib.rs to "Copyright 2018-2023 The kurbo Authors

You may use this library according to the MIT license or the Apache license version 2.0 at your discretion. Copies of both licenses are included with this crate on GitHub and crates.io."

and closing this issue once that change has been made. Does anyone disagree with this.

@derekdreery derekdreery added the needs discussion This change requires some more discussion before we decide we definitely want it label Mar 18, 2023
@raphlinus
Copy link
Contributor

My personal feeling is that we can converge on a standard policy across linebender.

Each file has this header:

// Copyright <year of file creation> the kurbo Authors
// SPDX-License-Identifier: Apache-2.0 OR MIT

I believe this is rigorous (especially in cases where there may be multiple licenses in a repo, likely less a problem for kurbo) and not too invasive.

@xStrom
Copy link
Member

xStrom commented Mar 18, 2023

I think having a standard policy of that short header is fine.

I am slightly wondering about the capitalization though. Having the not capitalized follows title capitalization rules I guess. However for the name, at least for Xilem, Vello, Glazier - it would be capitalized. Is kurbo going to remain lower case?

@raphlinus
Copy link
Contributor

This has come up before. I used lowercase as it refers to the crate name. I don't have a super strong feeling, I think we can flip a coin as long as we're consistent.

@xStrom
Copy link
Member

xStrom commented Mar 18, 2023

Alright, in the case of kurbo that can work. With others there can be multiple crates per repo (like Druid has) so for having a unified header per repo I think going with the (capitalized) project name would be better. Then based on that I would also advocate the same choice for kurbo, just so the header format is consistent across linebender.

I'll volunteer to do the grunt work and submit the PR soon, both for kurbo and other repos.

github-merge-queue bot pushed a commit to linebender/druid that referenced this issue May 21, 2024
The Linebender standard for copyright headers was decided last year in
[kurbo#207](linebender/kurbo#207) as the
following:

```
// Copyright <year of file creation> the <Project> Authors
// SPDX-License-Identifier: Apache-2.0 OR MIT
```

This PR converts all file headers to this standard form. Note that Druid
is not dual licensed under MIT and is Apache 2.0 only.
github-merge-queue bot pushed a commit to linebender/druid that referenced this issue May 21, 2024
The Linebender standard for copyright headers was decided last year in
[kurbo#207](linebender/kurbo#207) as the
following:

```
// Copyright <year of file creation> the <Project> Authors
// SPDX-License-Identifier: Apache-2.0 OR MIT
```

This PR converts all file headers to this standard form. Note that Druid
is not dual licensed under MIT and is Apache 2.0 only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion This change requires some more discussion before we decide we definitely want it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants