-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to wgpu 0.20.1 #631
Merged
waywardmonkeys
merged 1 commit into
linebender:main
from
waywardmonkeys:update-wgpu-0.20.1
Jul 16, 2024
Merged
Update to wgpu 0.20.1 #631
waywardmonkeys
merged 1 commit into
linebender:main
from
waywardmonkeys:update-wgpu-0.20.1
Jul 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also updates `wgpu-core` and `wgpu-hal` to the corresponding versions (which are 0.21.x). This fixes some undefined behavior when building with Rust 1.79 and using the Direct3D 12 backend: gfx-rs/wgpu#5812 It also fixes an issue on OpenGL where non-sRGB was still using sRGB: gfx-rs/wgpu#5642
@simbleau I think you had an issue with color on OpenGL before. Would the sRGB-related fix here have helped you? |
DJMcNab
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the DirectX UB is new per-se, it's just that std now catches it by default
@DJMcNab The other important part is that the wgpu 0.20.0 release was yanked. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
This release is for: - #630 This will also include: - #631 - #619 Note that this will be a cherry-picked patch release from 0.2.0, so doesn't have all the changes there. This PR is to update the changelog on main, and will also be cherry-picked into the release branch. I will make a release branch and get sign-off on that before publishing.
DJMcNab
pushed a commit
to DJMcNab/vello
that referenced
this pull request
Jul 16, 2024
This also updates `wgpu-core` and `wgpu-hal` to the corresponding versions (which are 0.21.x). This fixes some undefined behavior when building with Rust 1.79 and using the Direct3D 12 backend: gfx-rs/wgpu#5812 It also fixes an issue on OpenGL where non-sRGB was still using sRGB: gfx-rs/wgpu#5642
DJMcNab
added a commit
to DJMcNab/vello
that referenced
this pull request
Jul 16, 2024
This release is for: - linebender#630 This will also include: - linebender#631 - linebender#619 Note that this will be a cherry-picked patch release from 0.2.0, so doesn't have all the changes there. This PR is to update the changelog on main, and will also be cherry-picked into the release branch. I will make a release branch and get sign-off on that before publishing.
DJMcNab
pushed a commit
that referenced
this pull request
Jul 16, 2024
This also updates `wgpu-core` and `wgpu-hal` to the corresponding versions (which are 0.21.x). This fixes some undefined behavior when building with Rust 1.79 and using the Direct3D 12 backend: gfx-rs/wgpu#5812 It also fixes an issue on OpenGL where non-sRGB was still using sRGB: gfx-rs/wgpu#5642
DJMcNab
added a commit
that referenced
this pull request
Jul 16, 2024
This release is for: - #630 This will also include: - #631 - #619 Note that this will be a cherry-picked patch release from 0.2.0, so doesn't have all the changes there. This PR is to update the changelog on main, and will also be cherry-picked into the release branch. I will make a release branch and get sign-off on that before publishing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates
wgpu-core
andwgpu-hal
to the corresponding versions (which are 0.21.x).This fixes some undefined behavior when building with Rust 1.79 and using the Direct3D 12 backend: gfx-rs/wgpu#5812
It also fixes an issue on OpenGL where non-sRGB was still using sRGB: gfx-rs/wgpu#5642