Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to wgpu 0.20.1 #631

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

waywardmonkeys
Copy link
Contributor

This also updates wgpu-core and wgpu-hal to the corresponding versions (which are 0.21.x).

This fixes some undefined behavior when building with Rust 1.79 and using the Direct3D 12 backend: gfx-rs/wgpu#5812

It also fixes an issue on OpenGL where non-sRGB was still using sRGB: gfx-rs/wgpu#5642

This also updates `wgpu-core` and `wgpu-hal` to the corresponding
versions (which are 0.21.x).

This fixes some undefined behavior when building with Rust 1.79
and using the Direct3D 12 backend: gfx-rs/wgpu#5812

It also fixes an issue on OpenGL where non-sRGB was still using
sRGB: gfx-rs/wgpu#5642
@waywardmonkeys
Copy link
Contributor Author

@simbleau I think you had an issue with color on OpenGL before. Would the sRGB-related fix here have helped you?

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the DirectX UB is new per-se, it's just that std now catches it by default

@waywardmonkeys
Copy link
Contributor Author

@DJMcNab The other important part is that the wgpu 0.20.0 release was yanked.

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Jul 16, 2024
Merged via the queue into linebender:main with commit b89a685 Jul 16, 2024
16 checks passed
@waywardmonkeys waywardmonkeys deleted the update-wgpu-0.20.1 branch July 16, 2024 12:52
github-merge-queue bot pushed a commit that referenced this pull request Jul 16, 2024
This release is for:
- #630

This will also include:
- #631
- #619

Note that this will be a cherry-picked patch release from 0.2.0, so
doesn't have all the changes there.
This PR is to update the changelog on main, and will also be
cherry-picked into the release branch. I will make a release branch and
get sign-off on that before publishing.
DJMcNab pushed a commit to DJMcNab/vello that referenced this pull request Jul 16, 2024
This also updates `wgpu-core` and `wgpu-hal` to the corresponding
versions (which are 0.21.x).

This fixes some undefined behavior when building with Rust 1.79 and
using the Direct3D 12 backend:
gfx-rs/wgpu#5812

It also fixes an issue on OpenGL where non-sRGB was still using sRGB:
gfx-rs/wgpu#5642
DJMcNab added a commit to DJMcNab/vello that referenced this pull request Jul 16, 2024
This release is for:
- linebender#630

This will also include:
- linebender#631
- linebender#619

Note that this will be a cherry-picked patch release from 0.2.0, so
doesn't have all the changes there.
This PR is to update the changelog on main, and will also be
cherry-picked into the release branch. I will make a release branch and
get sign-off on that before publishing.
DJMcNab pushed a commit that referenced this pull request Jul 16, 2024
This also updates `wgpu-core` and `wgpu-hal` to the corresponding
versions (which are 0.21.x).

This fixes some undefined behavior when building with Rust 1.79 and
using the Direct3D 12 backend:
gfx-rs/wgpu#5812

It also fixes an issue on OpenGL where non-sRGB was still using sRGB:
gfx-rs/wgpu#5642
DJMcNab added a commit that referenced this pull request Jul 16, 2024
This release is for:
- #630

This will also include:
- #631
- #619

Note that this will be a cherry-picked patch release from 0.2.0, so
doesn't have all the changes there.
This PR is to update the changelog on main, and will also be
cherry-picked into the release branch. I will make a release branch and
get sign-off on that before publishing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants