refactor(macro): remove whitespace cleaning from js macro

[timofei-iatsenko]

Description

As other developers noted, whitespace trimming is in JS macro redundant and counterintuitive.

If i write:

t`Hello 
world`

I'm expecting to get a message with a line break in the middle, and don't expect this to be trimmed.

Another example:

t`Label: ` + value

Note the space after ":", it's expected to be there, but "normalization" will remove it.

Other example would be a markdown, or just a whatever purpose user want to have an original formatting.

This PR completely remove whitespace trimming from JS macro, and left the value as-is.

Second important change

There was an unclear logic around unicode escaping in template literals, which I also removed in favor of always "cooked" value.

The template literal has 2 values, raw and cooked. For some historical reasons, the macro took a "raw" property (i followed git history up to creation of the file to see how this code evolved over time).

Then some additional cleanup happened over the "raw", for example double backslashes were removed to make line breaks works.

Then someone reported (#1098) that unicode sequences doesn't work, and an additional layer of logic was added. Now when there were any unicode sequences the code took "cooked" and "raw" when it's not.

Some of this "fixes" for "raw" string happened in the whitespace normalization process and become broken when I removed it.

I dug into that a little bit more, and found that using "cooked" value always give a correct result.

I'm a little bit concerned about this comment:

// if it's an unicode we keep the cooked value because it's the parsed value by babel (without unicode chars)
// This regex will detect if a string contains unicode chars, when they're we should interpolate them
// why? because platforms like react native doesn't parse them, just doing a JSON.parse makes them UTF-8 friendly

Since i didn't find any test covering this. @vonovak may be you can test these changes in React Native?

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Examples update

Fixes #1799

Checklist

• I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
• I have added tests that prove my fix is effective or that my feature works
• I have added the necessary documentation (if appropriate)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
js-lingui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 29, 2024 0:14am

[github-actions]

size-limit report 📦

Path	Size
./packages/core/dist/index.mjs	2.86 KB (0%)
./packages/detect-locale/dist/index.mjs	723 B (0%)
./packages/react/dist/index.mjs	1.67 KB (0%)
./packages/remote-loader/dist/index.mjs	7.26 KB (0%)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.16%. Comparing base (b031df7) to head (3fb9e80).

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #1897      +/-   ##
==========================================
- Coverage   77.18%   77.16%   -0.02%     
==========================================
  Files          84       84              
  Lines        2165     2159       -6     
  Branches      559      557       -2     
==========================================
- Hits         1671     1666       -5     
  Misses        381      381              
+ Partials      113      112       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vonovak]

Tested with RN, seems to work fine. You're on fire @thekip !! ⚡⚡