feat(react): preserve newlines during string formatting #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
|
Have you seen these two merged pull requests? The changes are already released with a |
|
Thanks @Garbanas for the contribution! As @thekip said, this has already been implemented in the Feel free to try the 5.0.0-next.0 release and let us know if it works as expected for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change will preserve newline characters also for translations in
@lingui/reactwhen<tags>are present. Newlines are already preserved for values with no tags or just simple placeholders.This PR ensures that formatting is done the same way for both variants: with and without
<tags>.The benefit is that CSS rules or tags that rely on preservation of newlines now work with
<tags>.See https://developer.mozilla.org/en-US/docs/Web/CSS/white-space#pre-line
Types of changes
Depending on your view, this is either a bugfix (ensuring that formatting works the same across variants), or a breaking change (changes the newline behaviour for a formatting variant).
Checklist