Fix a bug in ResponseInfo.release (#1330)

Increment numChunksWrittenOut before releasing the responseInfo might end up another thread calling completeRead at the same time. We might see the same ResponseInfo being released twice.
linkedin · Dec 6, 2019 · 6e43fda · 6e43fda
1 parent ca1c9be
commit 6e43fda
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/ambry-router/src/main/java/com.github.ambry.router/GetBlobOperation.java b/ambry-router/src/main/java/com.github.ambry.router/GetBlobOperation.java
@@ -339,11 +339,12 @@ public void onCompletion(Long result, Exception exception) {
         if (exception != null) {
           setOperationException(exception);
         }
-        int currentNumChunk = numChunksWrittenOut.getAndIncrement();
+        int currentNumChunk = numChunksWrittenOut.get();
         ResponseInfo responseInfo = chunkIndexToResponseInfo.remove(currentNumChunk);
         if (responseInfo != null) {
           responseInfo.release();
         }
+        numChunksWrittenOut.incrementAndGet();
         routerCallback.onPollReady();
       }
     };