Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in ResponseInfo.release #1330

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

justinlin-linkedin
Copy link
Collaborator

Increment numChunksWrittenOut before releasing the responseInfo might end up another thread calling completeRead at the same time. We might see the same ResponseInfo being released twice.

@zzmao zzmao merged commit 6e43fda into linkedin:master Dec 6, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@c93821b). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1330   +/-   ##
=========================================
  Coverage          ?   72.18%           
  Complexity        ?     6503           
=========================================
  Files             ?      472           
  Lines             ?    37240           
  Branches          ?     4697           
=========================================
  Hits              ?    26883           
  Misses            ?     9109           
  Partials          ?     1248
Impacted Files Coverage Δ Complexity Δ
...java/com.github.ambry.router/GetBlobOperation.java 91.78% <100%> (ø) 39 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c93821b...958c171. Read the comment docs.

@justinlin-linkedin justinlin-linkedin deleted the fixresponserelease branch December 17, 2019 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants