Add a Metadata protobuf module
#123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we introduce HTTP routes (for inbound policy), we need the control plane to describe resources references for metrics, and other diagonstics in the proxy. Currently, the control plane uses a free-form map of strings, but the proxy only references a specific set of keys, which is not clearly documented via the gRPC API. This change replaces the `Authz` type's `labels` map with a `Metadata` type. Controllers should set both fields for at least one stable version. Signed-off-by: Oliver Gould <ver@buoyant.io>
|
looks like the CI build is broken due to missing imports...but only for docs? seems weird: https://github.com/linkerd/linkerd2-proxy-api/runs/7222796039?check_suite_focus=true |
hawkw
reviewed
Jul 6, 2022
Comment on lines
+7
to
+8
| // General metadata about a configuration object. Typically references either an | ||
| // implicit default configuration or a Kubernetes resource. |
There was a problem hiding this comment.
the semantics of the default variant is not super clear from this...is it expected to be populated with a string? how is that string handled?
There was a problem hiding this comment.
based on the current behavior of the policy-controller, I think this is supposed to describe what the default policy is (e.g. "all-authenticated"). But I agree, it's not clear.
Signed-off-by: Oliver Gould <ver@buoyant.io>
hawkw
approved these changes
Jul 6, 2022
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
adleong
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we introduce HTTP routes (for inbound policy), we need the control
plane to describe resources references for metrics, and other
diagonstics in the proxy. Currently, the control plane uses a free-form
map of strings, but the proxy only references a specific set of keys,
which is not clearly documented via the gRPC API.
This change replaces the
Authztype'slabelsmap with aMetadatatype. Controllers should set both fields for at least one stable
version.
Signed-off-by: Oliver Gould ver@buoyant.io