-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Metadata
protobuf module
#123
Changes from 7 commits
5c614e7
8000fb7
5aefcc4
2d27a46
fe0f67b
c88f81a
278e73e
f88cfc0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
syntax = "proto3"; | ||
|
||
package io.linkerd.proxy.meta; | ||
|
||
option go_package = "github.com/linkerd/linkerd2-proxy-api/go/meta"; | ||
|
||
// General metadata about a configuration object. Typically references either an | ||
// implicit default configuration or a Kubernetes resource. | ||
message Metadata { | ||
oneof kind { | ||
// A name describing a default/implicit configuration. | ||
// | ||
// For example, a policy default name like `all-authenticated` describes an | ||
// implicit controller-implemented policy that does not exist as a cluster | ||
// resource. | ||
string default = 1; | ||
|
||
Resource resource = 2; | ||
} | ||
} | ||
|
||
// References a (e.g., Kubernetes) resource. | ||
message Resource { | ||
string group = 1; | ||
string kind = 2; | ||
string name = 3; | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the semantics of the default variant is not super clear from this...is it expected to be populated with a string? how is that string handled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on the current behavior of the policy-controller, I think this is supposed to describe what the default policy is (e.g. "all-authenticated"). But I agree, it's not clear.