Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkerd mc allow broken in 2.11.x #8430

Closed
Tracked by #8779
alpeb opened this issue May 5, 2022 · 1 comment
Closed
Tracked by #8779

linkerd mc allow broken in 2.11.x #8430

alpeb opened this issue May 5, 2022 · 1 comment
Assignees
Labels
Milestone

Comments

@alpeb
Copy link
Member

alpeb commented May 5, 2022

What is the issue?

linkerd mc allow is erroring in 2.11.x. It works in edge.

How can it be reproduced?

$ linkerd mc allow --service-account-name foobar

Logs, error output, etc

$ linkerd mc allow --service-account-name foobar
Error: template: linkerd-multicluster/templates/remote-access-service-mirror-rbac.yaml:16:7: executing "linkerd-multicluster/templates/remote-access-service-mirror-rbac.yaml" at <include "partials.annotations.created-by" $>: error calling include: template: no template "partials.annotations.created-by" associated with template "gotpl"
Usage:
  linkerd multicluster allow [flags]

Flags:
  -h, --help                          help for allow
      --ignore-cluster                Ignore cluster configuration
      --namespace string              The destination namespace for the service account. (default "linkerd-multicluster")
      --service-account-name string   The name of the multicluster access service account

Global Flags:
      --api-addr string            Override kubeconfig and communicate directly with the control plane at host:port (mostly for testing)
      --as string                  Username to impersonate for Kubernetes operations
      --as-group stringArray       Group to impersonate for Kubernetes operations
      --cni-namespace string       Namespace in which the Linkerd CNI plugin is installed (default "linkerd-cni")
      --context string             Name of the kubeconfig context to use
      --kubeconfig string          Path to the kubeconfig file to use for CLI requests
  -L, --linkerd-namespace string   Namespace in which Linkerd is installed (default "linkerd")
      --verbose                    Turn on debug logging

output of linkerd check -o short

NA

Environment

linkerd 2.11.2

Possible solution

No response

Additional context

No response

Would you like to work on fixing this bug?

yes

@alpeb alpeb added the bug label May 5, 2022
@adleong adleong modified the milestones: stable-2.12.0, stable-2.11.2 May 10, 2022
@olix0r olix0r removed this from the stable-2.11.2 milestone Jun 9, 2022
@olix0r olix0r added this to the stable-2.11.3 milestone Jun 21, 2022
@kleimkuhler kleimkuhler self-assigned this Jun 27, 2022
kleimkuhler added a commit that referenced this issue Jun 28, 2022
Closes #8430

Change the chart rendering from `RenderNoPartials` to `Render` so that the
partials are properly rendered.

```shell
$ bin/build-cli-bin
$ bin/linkerd multicluster allow --service-account-name foo
...
```

Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
@kleimkuhler
Copy link
Contributor

Closed by #8756.

@kleimkuhler kleimkuhler mentioned this issue Jun 30, 2022
13 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants