Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render partials in linkerd multicluster allow #8756

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Render partials in linkerd multicluster allow #8756

merged 1 commit into from
Jun 28, 2022

Conversation

kleimkuhler
Copy link
Contributor

Closes #8430

Change the chart rendering from RenderNoPartials to Render so that the partials are properly rendered.

$ bin/build-cli-bin
$ bin/linkerd multicluster allow --service-account-name foo
...

Signed-off-by: Kevin Leimkuhler kleimkuhler@icloud.com

@kleimkuhler
Render partials in linkerd multicluster allow
3be5cf9 
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
@kleimkuhler kleimkuhler requested a review from a team as a code owner June 27, 2022 22:20
@kleimkuhler kleimkuhler requested a review from alpeb June 27, 2022 22:20
@kleimkuhler
Copy link
Contributor Author

This was already fixed on main by #6635 which is why this is merging into release/stable-2.11.

alpeb
alpeb approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @kleimkuhler !

@kleimkuhler kleimkuhler merged commit 07b6278 into release/stable-2.11 Jun 28, 2022
@kleimkuhler kleimkuhler deleted the kleimkuhler/mc-allow-fix branch June 28, 2022 20:59
@kleimkuhler kleimkuhler mentioned this pull request Jun 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adleong adleong adleong approved these changes

@alpeb alpeb alpeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kleimkuhler @alpeb @adleong