Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge the CLI 'installValues' type with Helm 'Values' type #3291

Merged
merged 10 commits into from
Aug 21, 2019
Merged

Merge the CLI 'installValues' type with Helm 'Values' type #3291

merged 10 commits into from
Aug 21, 2019

Commits on Aug 20, 2019

  1. Rename template-values.go 

    Signed-off-by: Ivan Sim <ivan@buoyant.io>
    Ivan Sim committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    faace34 View commit details
    Browse the repository at this point in the history

  2. Temp 

    Signed-off-by: Ivan Sim <ivan@buoyant.io>
    Ivan Sim committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    1220664 View commit details
    Browse the repository at this point in the history

  3. Define new constructor of charts.Values type 

    Signed-off-by: Ivan Sim <ivan@buoyant.io>
    Ivan Sim committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    63d7df7 View commit details
    Browse the repository at this point in the history

  4. Move all Helm values related code to the pkg/charts package 

    Signed-off-by: Ivan Sim <ivan@buoyant.io>
    Ivan Sim committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    05dcfc9 View commit details
    Browse the repository at this point in the history

  5. Bump dependency 

    Signed-off-by: Ivan Sim <ivan@buoyant.io>
    Ivan Sim committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    58ba4c3 View commit details
    Browse the repository at this point in the history

  6. Use '/' in filepath to remain compatible with VFS requirement 

    Signed-off-by: Ivan Sim <ivan@buoyant.io>
    Ivan Sim committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    f866de2 View commit details
    Browse the repository at this point in the history

  7. Add unit test to verify Helm YAML output 

    Signed-off-by: Ivan Sim <ivan@buoyant.io>
    Ivan Sim committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    b871fa6 View commit details
    Browse the repository at this point in the history

  8. Alejandro's feedback 

    Signed-off-by: Ivan Sim <ivan@buoyant.io>
    Ivan Sim committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    2015192 View commit details
    Browse the repository at this point in the history

  9. Add unit test for Helm YAML validation (HA) 

    Signed-off-by: Ivan Sim <ivan@buoyant.io>
    Ivan Sim committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    23af82d View commit details
    Browse the repository at this point in the history

  10. Remove redundant test fixture 

    Signed-off-by: Ivan Sim <ivan@buoyant.io>
    Ivan Sim committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    c837f23 View commit details
    Browse the repository at this point in the history