Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Add InfoModule class to simplify info module implementations #409

Merged
merged 12 commits into from
Sep 19, 2023

Conversation

lgarber-akamai
Copy link
Contributor

@lgarber-akamai lgarber-akamai commented Sep 13, 2023

📝 Description

This change adds a shared InfoModuleBase class that allows for the easy creation of info modules with very little boilerplate.

This change also switches from directly calling pytest to using the ansible-test units wrapper.

✔️ How to Test

make TEST_ARGS="-v instance_basic" test
make TEST_ARGS="-v stackscript_info" test

@lgarber-akamai lgarber-akamai marked this pull request as ready for review September 14, 2023 20:17
@lgarber-akamai lgarber-akamai requested a review from a team as a code owner September 14, 2023 20:17
@lgarber-akamai lgarber-akamai changed the title new: [DRAFT] Add InfoModuleBase class to simplify info module implementations new: Add InfoModuleBase class to simplify info module implementations Sep 14, 2023
@lgarber-akamai lgarber-akamai changed the title new: Add InfoModuleBase class to simplify info module implementations new: Add InfoModule class to simplify info module implementations Sep 14, 2023
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Tests passed locally 🎉

@lgarber-akamai lgarber-akamai requested a review from a team September 19, 2023 15:59
@amisiorek-akamai
Copy link
Contributor

amisiorek-akamai commented Sep 19, 2023

Tests pass locally with the exception of one from instance_basic, just want to double check that this is outside our scope.

TASK [instance_basic : Create a Linode instance with additional ips and without a root password] *** fatal: [testhost]: FAILED! => {"changed": false, "msg": "Error from Linode API: [400] Additional IPv4 addresses require technical justification. Please contact support describing your requirement"}

@lgarber-akamai lgarber-akamai merged commit 1ff5049 into linode:dev Sep 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants