Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Introduce ListModule class to simplify list module implementations #410

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

lgarber-akamai
Copy link
Contributor

@lgarber-akamai lgarber-akamai commented Sep 15, 2023

📝 Description

This PR adds a new ListModule class that significantly reduces the amount of boilerplate required in list module implementations.

Depends on #409

Relevant Changes

✔️ How to Test

make TEST_ARGS="-v image_list" test

@lgarber-akamai lgarber-akamai requested a review from a team as a code owner September 15, 2023 16:56
@lgarber-akamai lgarber-akamai added the do-not-merge PRs that should not be merged until the commented issue is resolved label Sep 15, 2023
@jriddle-linode jriddle-linode requested a review from a team September 19, 2023 16:22
Copy link
Contributor

@amisiorek-akamai amisiorek-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass locally!

@lgarber-akamai lgarber-akamai merged commit d6a855b into linode:dev Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge PRs that should not be merged until the commented issue is resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants