ci: Fix workflow failures in PRs due to slack notify step #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykim-akamai
added
the
repo-ci-improvement
ykim-akamai
requested review from
jriddle-linode and
ezilber-akamai
and removed request for
a team
zliang-akamai
approved these changes
Oct 7, 2024
ezilber-akamai
added a commit
that referenced
this pull request
Oct 25, 2024
* Unit tests passing * Remove all references to Resty * Fixed some integration tests * Fixed failing integration tests * Fix lint * Fixed request body not being logged * Fixed issue where request body did not get reset for retry * Fix lint * Fixed issue with image uploads * build(deps): bump golang.org/x/text from 0.18.0 to 0.19.0 (#587) * build(deps): bump golang.org/x/text from 0.18.0 to 0.19.0 Bumps [golang.org/x/text](https://github.com/golang/text) from 0.18.0 to 0.19.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.18.0...v0.19.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Ran make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ezilber-akamai <ezilber@akamai.com> * ci: Fix workflow failures in PRs due to slack notify step (#588) * allow some vars to be shared * add target branch * remove target branch * revert to push_request and only run slack notify when push to main * Fixed intermittent error * Addressed more PR comments * Addressed more PR comments * Addressed some more PR comments * Added default values for retry times * Updated body type in requestParams * Addressed more PR comments --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Youjung Kim <126618609+ykim-1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Workflow have been failing due to secrets not being available to other forked branches due to ci.yml workflow running in untrusted mode. Hence only run slack notify on push to main branch
This will fix workflow failing in open PRs. E.g. https://github.com/linode/linodego/actions/runs/11218320749/job/31181851076?pr=576
✔️ How to Test
Refer to the checks in this PR, slack notify step should be excluded
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.