Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix workflow failures in PRs due to slack notify step #588

Merged
merged 5 commits into from
Oct 7, 2024
Merged

ci: Fix workflow failures in PRs due to slack notify step #588

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cc0df9e
allow some vars to be shared
ykim-akamai Oct 7, 2024
c52a176
add target branch
ykim-akamai Oct 7, 2024
f1f6160
remove target branch
ykim-akamai Oct 7, 2024
0b66303
revert to push_request and only run slack notify when push to main
ykim-akamai Oct 7, 2024
8620abf
Merge branch 'main' into fix/workflows_share_vars_in_main_repo
ykim-akamai Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:

- name: Fail if changes
run: git diff-index --exit-code HEAD

test:
runs-on: ubuntu-latest
env:
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
notify-slack:
runs-on: ubuntu-latest
needs: [test]
if: always() && github.repository == 'linode/linodego' # Run even if integration tests fail and only on main repository
if: always() && github.ref == 'refs/heads/main' && github.event_name == 'push' # Run even if integration tests fail and only on main repository

steps:
- name: Notify Slack
Expand Down