Merge pull request #3 from patthiel/longview-fixes

Longview test fixes
linode · Dec 16, 2019 · a540250 · a540250
2 parents dcdf738 + 0c2c092
commit a540250
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/packages/manager/e2e/config/wdio.conf.js b/packages/manager/e2e/config/wdio.conf.js
@@ -85,6 +85,7 @@ exports.config = {
   // debug: true,
   // execArgv: ['--inspect=127.0.0.1:5859'],
   // Selenium Host/Port
+  runner: 'local',
   hostname: process.env.DOCKER ? 'selenium' : 'localhost',
   port: 4444,
   //

diff --git a/packages/manager/e2e/pageobjects/longview/longview-landing.page.js b/packages/manager/e2e/pageobjects/longview/longview-landing.page.js
@@ -1,4 +1,5 @@
 const { assertLog } = require('../../utils/assertionLog');
+const { constants } = require('../../constants');
 import Page from '../page';
 
 class LongviewLanding extends Page {
@@ -116,7 +117,7 @@ class LongviewLanding extends Page {
     this.deleteButton.click();
     this.dialogAlert.waitForDisplayed();
     this.lvDelete.click();
-    this.dialogAlert.waitForDisplayed(true);
+    this.dialogAlert.waitForExist(constants.wait.normal, true);
   }
 
   deleteLVClientsAPI(token, lvClients) {

diff --git a/packages/manager/e2e/pageobjects/longview/longview-plan-details.page.js b/packages/manager/e2e/pageobjects/longview/longview-plan-details.page.js
@@ -49,8 +49,8 @@ class LongviewPlanDetails extends Page {
 
   isCurrentPlan(clientCount) {
     return $(
-      `[data-testid=lv-sub-table-row-longview-${clientCount}] [data-testid=current-plan]`
-    ).isDisplayed();
+      `[data-testid="lv-sub-table-row-longview-${clientCount}"] [data-testid="current-plan"]`
+    ).isExisting();
   }
 
   resetToFree() {
@@ -104,7 +104,7 @@ class LongviewPlanDetails extends Page {
     expect(this.isCurrentPlan(clientCount))
       .withContext(`should be current plan`)
       .toBe(true);
-    expect(planRow.$('data-qa-radio=true]'))
+    expect(planRow.$('[data-qa-radio="true"]').isEnabled())
       .withContext(`Plan radio button ${assertLog.enabled}`)
       .toBe(true);
 

diff --git a/packages/manager/e2e/specs/longview/longview-plan-details.spec.js b/packages/manager/e2e/specs/longview/longview-plan-details.spec.js
@@ -91,12 +91,13 @@ describe('longview suite', () => {
         LongviewPlan.planDetailsDisplay();
       }
     });
+
     it('checks that longview plan can be changed', () => {
-      // checks for managed account
+      // // checks for managed account
       expect(LongviewLanding.checkForManaged(token))
         .withContext(`${managedAccount}`)
         .toBe(false);
-      // Changes a plan
+      // // Changes a plan
       expect(LongviewPlan.isCurrentPlan('free'))
         .withContext(`free plan should be set`)
         .toBe(true);
@@ -117,7 +118,7 @@ describe('longview suite', () => {
       const lvError = `Too many active Longview clients (${clientCount.length}) for the subscription selected (3). Select a larger subscription or reduce the number of Longview clients.`;
       LongviewPlan.lv3Plan.click();
       LongviewPlan.changePlanButton.click();
-      $('[data-qa-notice').waitForDisplayed();
+      $('[data-qa-notice]').waitForDisplayed();
       expect($('[data-qa-error="true"]').isDisplayed())
         .withContext(`Client count error ${assertLog.displayed}`)
         .toBe(true);