Test linode power #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, this is fine. As long as this works, I'm fine with it. I'll submit another PR cleaning things up. Ready to merge? |
alioso
added a commit
that referenced
this pull request
Mar 1, 2019
johnwcallahan
referenced
this pull request
in johnwcallahan/manager
May 16, 2019
App.tsx fetches `profile`, which is now used to determine if OBJ is enabled. We used to request buckets and clusters on initial App load, but now we need to wait for the profile response. I could have: 1) Implemented getProfile().then(() => getEverythingElse()) sort of logic. 2) Added CDU logic to App.tsx to check if profile has been loaded, THEN maybe do OBJ requests. 3) Move OBJ requests to ObjectStorageLanding. I opted for #3, because the first two options resulted in a performance hit for all users. We could move these requests back to App.tsx once OBJ is generally available.
johnwcallahan
added a commit
that referenced
this pull request
May 22, 2019
…ed. (#4916) * Use /profile to determine isObjectStorageEnabled Previously, OBJ was enabled per environment, set by a variable in .env. Now, we ALSO check the response on /profile, which may return `beta_programs: ["Object Storage EAP"]`. If a user is enrolled in the Object Storage EAP beta program, we enable OBJ, even if it's globally disabled for the environment. This allows us to enable OBJ per-customer in a production environment. * Use fuzzier string matching (review feedback) * Update CDU logic in PrimaryNav (review feedback) Check to see if `profile` has been updated, because profile.beta_programs could have changed, which means that we might need to show different menu items. Also check if the account is managed for the same reason. * Move OBJ requests to OBJ Landing instead of App App.tsx fetches `profile`, which is now used to determine if OBJ is enabled. We used to request buckets and clusters on initial App load, but now we need to wait for the profile response. I could have: 1) Implemented getProfile().then(() => getEverythingElse()) sort of logic. 2) Added CDU logic to App.tsx to check if profile has been loaded, THEN maybe do OBJ requests. 3) Move OBJ requests to ObjectStorageLanding. I opted for #3, because the first two options resulted in a performance hit for all users. We could move these requests back to App.tsx once OBJ is generally available. * Dispatch requestAccount() on App load * Add Linode.AccountCapability type This is currently only returned from the beta API, so it is not yet included on the Account interface. * Use account.capabilities vs. profile.beta_programs * Add missing PrimaryNav test * Update accountCapabilities tests * Fix comment * Add loading and errors states We show a loading state if we don’t have a response from /account yet, otherwise there would be a brief 404 while /account loads if you go to /object-storage/buckets directly. We also handle the request to /account resulting in an error. * Use React.FC instead of StatelessComponent * Add LandingLoading component This component accepts props that control delay of rendering the component. It could potentially be used for everywhere we display <CircleProgress /> on a Landing page. * Use <LandingLoading /> and simplify Error state
santoshp210-akamai
referenced
this pull request
in santoshp210-akamai/manager
Feb 13, 2024
Feature/cloudview section
bnussman-akamai
added a commit
that referenced
this pull request
Aug 8, 2024
…noreDeprecations` Typescript Options (#10755) * save changes #1 * save changes #2 * save changes #3 * save changes #4 * save changes #5 * save changes #6 * save changes #7 * save changes #8 * fix image select * save changes #9 * save changes #10 * last issue is filtering * fix unit test by fixing button types * finally resolved all tsc errors * Added changeset: Remove `suppressImplicitAnyIndexErrors` and `ignoreDeprecations` Typescript Options * fix cypress feature flag util hopefully * another attemnpt to fix cypress feature flag util function * make image select close onSelect to match previous behavior * feedback @jaalah-akamai --------- Co-authored-by: Banks Nussman <banks@nussman.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, GitHub glitch when switching to public.