Fix repeated test runs #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you ran the tests several times, some things would be saved in localStorage, causing tests to possibly fail.
| const array_to_set = arr => arr.reduce((s, v) => ({ ...s, [v]: true }), { }); | ||
|
|
||
| export function index(state=default_state, action) { | ||
| export function index(state=null, action) { | ||
| if (state === null) { |
There was a problem hiding this comment.
Why not no default argument for state and just if (!state) {? Also, this appears to be identical to what it was before except basically ignoring default arguments. Could you explain how this solved the problem?
There was a problem hiding this comment.
=== > truthy compares imo
There was a problem hiding this comment.
And this postpones talking to localStorage until the reducer is invoked.
|
ok looks good. ready to merge? |
|
Yes. |
|
Thanks! |
bnussman-akamai
pushed a commit
to bnussman-akamai/manager
that referenced
this pull request
Aug 5, 2024
bnussman-akamai
added a commit
that referenced
this pull request
Aug 8, 2024
…noreDeprecations` Typescript Options (#10755) * save changes #1 * save changes #2 * save changes #3 * save changes #4 * save changes #5 * save changes #6 * save changes #7 * save changes #8 * fix image select * save changes #9 * save changes #10 * last issue is filtering * fix unit test by fixing button types * finally resolved all tsc errors * Added changeset: Remove `suppressImplicitAnyIndexErrors` and `ignoreDeprecations` Typescript Options * fix cypress feature flag util hopefully * another attemnpt to fix cypress feature flag util function * make image select close onSelect to match previous behavior * feedback @jaalah-akamai --------- Co-authored-by: Banks Nussman <banks@nussman.us>
dwiley-akamai
pushed a commit
to dwiley-akamai/manager
that referenced
this pull request
Sep 17, 2024
…s_automation upcoming: [DI-20585] - Flow update for widget tests
nikhagra-akamai
pushed a commit
to nikhagra-akamai/manager
that referenced
this pull request
Oct 8, 2024
…ode#8) * upcoming: [DI-20800] - Tooltip changes * upcoming: [DI-20800] - Tooltip and publishing the resource selection onClose from Autocomplete * upcoming: [DI-20800] - Resource Selection close state handling updates * upcoming: [DI-20800] - Tooltip code refactoring * upcoming: [DI-20800] - Tooltip code refactoring * upcoming: [DI-20800] - Global Filters * upcoming: [DI-20800] - As per dev * upcoming: [DI-20800] - Code clean up and refactoring * upcoming: [DI-20800] - UT fixes * upcoming: [DI-20800] - Code clean up and review comments --------- Co-authored-by: vmangalr <vmangalr@akamai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you ran the tests several times, some things would be saved in
localStorage, causing tests to possibly fail.