Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8108, M3-8113] - Improve security of Linodes created by tests #10538

Merged

Conversation

jdamore-linode
Copy link
Contributor

@jdamore-linode jdamore-linode commented May 31, 2024

Description 📝

This improves the security of Linodes created by the tests. It does this by modifying our createTestLinode() util and by updating each of our tests to use this util rather than creating a Linode directly with the API SDK's createLinode function.

The createTestLinode util enforces that some security method is applied to the Linode. There are 3 options that are each applicable in different situations:

  • firewall: places the created Linode behind a locked down Firewall. This is the default security method and is suitable for most cases.
  • vlan_no_internet: creates the Linode without a network interface for public internet access.
  • powered_off: creates the Linode but does not boot it.

Changes 🔄

  • Update createTestLinode so that created Linode is either behind a firewall, is not connected to the internet, or is not booted
  • Update tests to use this util

Target release date 🗓️

Please specify a release date to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

How to test 🧪

yarn cy:run

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jdamore-linode jdamore-linode self-assigned this May 31, 2024
@jdamore-linode jdamore-linode requested a review from a team as a code owner May 31, 2024 20:25
@jdamore-linode jdamore-linode requested review from cliu-akamai and removed request for a team May 31, 2024 20:25
@jdamore-linode jdamore-linode requested a review from a team as a code owner May 31, 2024 20:29
@jdamore-linode jdamore-linode requested review from jaalah-akamai and AzureLatte and removed request for a team May 31, 2024 20:29
Copy link

github-actions bot commented May 31, 2024

Coverage Report:
Base Coverage: 82.35%
Current Coverage: 82.35%

Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really great (and important) update @jdamore-linode - thanks for tackling this

Copy link
Contributor

@AzureLatte AzureLatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jdamore-linode jdamore-linode added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Jun 4, 2024
@jdamore-linode jdamore-linode merged commit 684c38c into linode:develop Jun 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants