-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-8108, M3-8113] - Improve security of Linodes created by tests #10538
test: [M3-8108, M3-8113] - Improve security of Linodes created by tests #10538
Conversation
…with the test flow
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really great (and important) update @jdamore-linode - thanks for tackling this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description 📝
This improves the security of Linodes created by the tests. It does this by modifying our
createTestLinode()
util and by updating each of our tests to use this util rather than creating a Linode directly with the API SDK'screateLinode
function.The
createTestLinode
util enforces that some security method is applied to the Linode. There are 3 options that are each applicable in different situations:firewall
: places the created Linode behind a locked down Firewall. This is the default security method and is suitable for most cases.vlan_no_internet
: creates the Linode without a network interface for public internet access.powered_off
: creates the Linode but does not boot it.Changes 🔄
createTestLinode
so that created Linode is either behind a firewall, is not connected to the internet, or is not bootedTarget release date 🗓️
Please specify a release date to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
How to test 🧪
As an Author I have considered 🤔
Check all that apply