-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-8122] - Disable access to internet for Linodes created during Cypress tests #10633
Merged
jdamore-linode
merged 2 commits into
linode:develop
from
jdamore-linode:M3-8122-disable-public-internet-e2e-linodes
Jul 2, 2024
Merged
test: [M3-8122] - Disable access to internet for Linodes created during Cypress tests #10633
jdamore-linode
merged 2 commits into
linode:develop
from
jdamore-linode:M3-8122-disable-public-internet-e2e-linodes
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdamore-linode
changed the title
Place Linodes created by Cypress tests behind VLAN, increase Clone ti…
test: [M3-8122] - Disable access to internet for Linodes created during Cypress tests
Jul 1, 2024
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Jul 1, 2024
jdamore-linode
requested review from
mjac0bs and
AzureLatte
and removed request for
a team
July 2, 2024 15:38
AzureLatte
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
mjac0bs
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mjac0bs
added
Approved
Multiple approvals and ready to merge!
and removed
Ready for Review
labels
Jul 2, 2024
nikhagra-akamai
pushed a commit
to nikhagra-akamai/manager
that referenced
this pull request
Jul 3, 2024
…ng Cypress tests (linode#10633) * Place Linodes created by Cypress tests behind VLAN, increase Clone timeout * Add changeset
This was referenced Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This modifies our Cypress tests so that any Linodes created during the course of a test are created with no access to the internet. It does this by modifying the
interceptCreateLinode
util to mutate the outgoing request.Note that this applies only to Linodes that are created via Cloud Manager during the tests -- Linodes created directly by Cypress via our JS SDK already have extra measures taken to secure them (see #10538).
Changes 🔄
How to test 🧪
ping <IP address>
and confirm that you cannot connectssh root@<IP address>
and confirm that you cannot connectyarn cy:debug
with the Chrome dev tools openping 1.1.1.1
and confirm that there is no internet connectivityAs an Author I have considered 🤔
Check all that apply