Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-8508] - Cancel Button Not Functioning in Delete Node Balancer Configuration Dialog #10962

Merged
merged 34 commits into from
Sep 24, 2024

Conversation

cpathipa
Copy link
Contributor

@cpathipa cpathipa commented Sep 18, 2024

Description πŸ“

This PR fix the issue Cancel Button not functioning inDelete Node Balancer Configuration Dialog.

Target release date πŸ—“οΈ

9/30

Preview

CancelButton_NB.mov

How to test πŸ§ͺ

Verification steps

(How to verify changes)

  • Navigate to Nodebalancer, then create a node balancer, then try to delete its configuration and click 'cancel' button in the dialog.
  • Verify that cancel button should function as expected.

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

cpathipa added 27 commits June 19, 2024 09:06
@cpathipa cpathipa requested a review from a team as a code owner September 18, 2024 14:54
@cpathipa cpathipa requested review from hana-akamai and removed request for a team September 18, 2024 14:54
@cpathipa cpathipa self-assigned this Sep 18, 2024
@cpathipa cpathipa marked this pull request as draft September 18, 2024 14:54
Copy link

github-actions bot commented Sep 18, 2024

Coverage Report: βœ…
Base Coverage: 87.13%
Current Coverage: 87.13%

@cpathipa cpathipa marked this pull request as ready for review September 18, 2024 15:26
Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpathipa can you give more context to why the cancel button wasn't working before?

@cpathipa
Copy link
Contributor Author

@cpathipa can you give more context to why the cancel button wasn't working before?

@hana-linode I believe the issue is due to handler not binded to the context, where click action is not picking up earlier. Any thoughts in handling this in a better way? one of reason for abstraction is NodeBalancerConfigurations file its self is too large and added the tests to make sure handlers are called while using ActionsPanel in this component and specific to the defect.

@cpathipa cpathipa added the Add'tl Approval Needed Waiting on another approval! label Sep 24, 2024
@hana-akamai hana-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! Ready for Review labels Sep 24, 2024
@cpathipa cpathipa merged commit 915faca into linode:develop Sep 24, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants