-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-8508] - Cancel Button Not Functioning in Delete Node Balancer Configuration Dialog #10962
Conversation
This reverts commit b274baf.
β¦r Configuration Dialog
Coverage Report: β
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpathipa can you give more context to why the cancel button wasn't working before?
...ager/src/features/NodeBalancers/NodeBalancerDetail/NodeBalancerConfigConfirmationActions.tsx
Outdated
Show resolved
Hide resolved
β¦r Configuration Dialog
@hana-linode I believe the issue is due to handler not binded to the context, where click action is not picking up earlier. Any thoughts in handling this in a better way? one of reason for abstraction is NodeBalancerConfigurations file its self is too large and added the tests to make sure handlers are called while using ActionsPanel in this component and specific to the defect. |
Description π
This PR fix the issue Cancel Button not functioning inDelete Node Balancer Configuration Dialog.
Target release date ποΈ
9/30
Preview
CancelButton_NB.mov
How to test π§ͺ
Verification steps
(How to verify changes)
As an Author I have considered π€
Check all that apply