Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-8508] - Cancel Button Not Functioning in Delete Node Balancer Configuration Dialog #10962

Merged
merged 34 commits into from
Sep 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
b274baf
unit test coverage for HostNameTableCell
cpathipa Jun 19, 2024
f958dab
Revert "unit test coverage for HostNameTableCell"
cpathipa Jun 19, 2024
5d0a476
Merge branch 'linode:develop' into develop
cpathipa Jun 25, 2024
93aab07
Merge branch 'linode:develop' into develop
cpathipa Jun 25, 2024
d7deb4f
Merge branch 'linode:develop' into develop
cpathipa Jul 1, 2024
a550f05
Merge branch 'linode:develop' into develop
cpathipa Jul 3, 2024
de0f63e
Merge branch 'linode:develop' into develop
cpathipa Jul 5, 2024
426c42c
Merge branch 'linode:develop' into develop
cpathipa Jul 17, 2024
3fb49a6
Merge branch 'linode:develop' into develop
cpathipa Jul 22, 2024
6c76508
Merge branch 'linode:develop' into develop
cpathipa Jul 24, 2024
1653a6b
Merge branch 'linode:develop' into develop
cpathipa Jul 25, 2024
00421cf
Merge branch 'linode:develop' into develop
cpathipa Jul 29, 2024
959730a
Merge branch 'linode:develop' into develop
cpathipa Jul 31, 2024
d9bd490
Merge branch 'linode:develop' into develop
cpathipa Jul 31, 2024
960415e
Merge branch 'linode:develop' into develop
cpathipa Aug 1, 2024
b9f4745
Merge branch 'linode:develop' into develop
cpathipa Aug 2, 2024
b0b9264
Merge branch 'linode:develop' into develop
cpathipa Aug 21, 2024
6c70559
Merge branch 'linode:develop' into develop
cpathipa Aug 28, 2024
96eb34d
Merge branch 'linode:develop' into develop
cpathipa Sep 3, 2024
74b1635
Merge branch 'linode:develop' into develop
cpathipa Sep 4, 2024
70d1422
Merge branch 'linode:develop' into develop
cpathipa Sep 5, 2024
342fd96
Merge branch 'linode:develop' into develop
cpathipa Sep 9, 2024
bfed239
Merge branch 'linode:develop' into develop
cpathipa Sep 13, 2024
8a19f9b
Merge branch 'linode:develop' into develop
cpathipa Sep 17, 2024
9e9c14f
Merge branch 'linode:develop' into develop
cpathipa Sep 17, 2024
a25728e
Merge branch 'linode:develop' into develop
cpathipa Sep 18, 2024
525c9bd
fix: [M3-8508] - Cancel Button Not Functioning in Delete Node Balance…
cpathipa Sep 18, 2024
d2436ef
Add unit test coverage
cpathipa Sep 18, 2024
919d487
Added changeset: Cancel Button Not Functioning in Delete Node Balance…
cpathipa Sep 18, 2024
3196f2a
Merge branch 'linode:develop' into develop
cpathipa Sep 19, 2024
4794d04
Merge branch 'linode:develop' into develop
cpathipa Sep 23, 2024
e977a94
Merge branch 'linode:develop' into develop
cpathipa Sep 24, 2024
02a5c12
Merge remote-tracking branch 'origin/develop' into M3-8508
cpathipa Sep 24, 2024
e749e1b
PR feedback - @HanaXu
cpathipa Sep 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-10962-fixed-1726688754577.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Fixed
---

Cancel Button Not Functioning in Delete Node Balancer Configuration Dialog ([#10962](https://github.com/linode/manager/pull/10962))
Original file line number Diff line number Diff line change
Expand Up @@ -692,23 +692,6 @@ class NodeBalancerConfigurations extends React.Component<
);
};

renderConfigConfirmationActions = ({ onClose }: { onClose: () => void }) => (
<ActionsPanel
primaryButtonProps={{
'data-testid': 'confirm-cancel',
label: 'Delete',
loading: this.state.deleteConfigConfirmDialog.submitting,
onClick: this.deleteConfig,
}}
secondaryButtonProps={{
'data-testid': 'cancel-cancel',
label: 'Cancel',
onClick: onClose,
}}
style={{ padding: 0 }}
/>
);

resetSubmitting = (configIdx: number) => {
// reset submitting
const newSubmitting = clone(this.state.configSubmitting);
Expand Down Expand Up @@ -1146,13 +1129,28 @@ class NodeBalancerConfigurations extends React.Component<
)}

<ConfirmationDialog
actions={
<ActionsPanel
primaryButtonProps={{
'data-testid': 'confirm-cancel',
label: 'Delete',
loading: this.state.deleteConfigConfirmDialog.submitting,
onClick: this.deleteConfig,
}}
secondaryButtonProps={{
'data-testid': 'cancel-cancel',
label: 'Cancel',
onClick: this.onCloseConfirmation,
}}
style={{ padding: 0 }}
/>
}
title={
typeof this.state.deleteConfigConfirmDialog.portToDelete !==
'undefined'
? `Delete this configuration on port ${this.state.deleteConfigConfirmDialog.portToDelete}?`
: 'Delete this configuration?'
}
actions={this.renderConfigConfirmationActions}
error={this.confirmationConfigError()}
onClose={this.onCloseConfirmation}
open={this.state.deleteConfigConfirmDialog.open}
Expand Down
Loading