-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-8446] - Add cypress test for Object Storage gen 2 Access Keys landing page #10984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report: β
|
hkhalil-akamai
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass locally!
@@ -9,7 +9,7 @@ interface StyledLastColumnCellProps extends TableCellProps { | |||
addPaddingRight?: boolean; | |||
} | |||
export const StyledLastColumnCell = styled(TableCell, { | |||
shouldForwardProp: omittedProps(['isObjMultiClusterEnabled']), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catchπ
hana-akamai
approved these changes
Sep 25, 2024
Cloud Manager E2EΒ
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
|
Run duration | 28m 33s |
Commit |
|
Committer | Connie Liu |
View all properties for this run βοΈ |
Test results | |
---|---|
|
2
|
|
4
|
|
2
|
|
3
|
|
404
|
View all changes introduced in this branch βοΈ |
Tests for review
Β linodes/rebuild-linode.spec.ts β’ 1 failed test
Test | Artifacts | |
---|---|---|
rebuild linode > rebuilds a linode from Image |
Screenshots
Video
|
Β images/machine-image-upload.spec.ts β’ 1 failed test
Test | Artifacts | |
---|---|---|
machine image > uploads machine image, mock expired upload event |
Screenshots
Video
|
Β linodes/clone-linode.spec.ts β’ 1 flaky test
Test | Artifacts | |
---|---|---|
clone linode > can clone a Linode from Linode details page |
Screenshots
Video
|
Β images/machine-image-upload.spec.ts β’ 1 flaky test
Test | Artifacts | |
---|---|---|
machine image > uploads machine image, mock upload canceled failed event |
Screenshots
Video
|
Β placementGroups/delete-placement-groups.spec.ts β’ 1 flaky test
Test | Artifacts | |
---|---|---|
Placement Group deletion > can delete with Linodes assigned when unexpected error show up and retry |
Screenshots
Video
|
Β kubernetes/smoke-lke-create.spec.ts β’ 1 flaky test
Test | Artifacts | |
---|---|---|
LKE Create Cluster > Simple Page Check |
Screenshots
Video
|
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description π
Changes π
Target release date ποΈ
9/30+
How to test π§ͺ
yarn cy:run -s "cypress/e2e/core/objectStorageGen2/bucket-access-keys-gen2.spec.ts"
As an Author I have considered π€
Check all that apply