Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8446] - Add cypress test for Object Storage gen 2 Access Keys landing page #10984

Merged
merged 6 commits into from
Sep 30, 2024

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Sep 23, 2024

Description πŸ“

  • Adds integration test using mock data to confirm Access Keys landing page flow

Changes πŸ”„

  • add cypress test
  • updated a styled component to remove dom warning

Target release date πŸ—“οΈ

9/30+

How to test πŸ§ͺ

  • yarn cy:run -s "cypress/e2e/core/objectStorageGen2/bucket-access-keys-gen2.spec.ts"

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@coliu-akamai coliu-akamai self-assigned this Sep 23, 2024
@coliu-akamai coliu-akamai marked this pull request as ready for review September 23, 2024 13:37
@coliu-akamai coliu-akamai requested review from a team as code owners September 23, 2024 13:37
@coliu-akamai coliu-akamai requested review from jdamore-linode, hana-akamai and hkhalil-akamai and removed request for a team September 23, 2024 13:37
Copy link

github-actions bot commented Sep 23, 2024

Coverage Report: βœ…
Base Coverage: 87.13%
Current Coverage: 87.13%

Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally!

@@ -9,7 +9,7 @@ interface StyledLastColumnCellProps extends TableCellProps {
addPaddingRight?: boolean;
}
export const StyledLastColumnCell = styled(TableCell, {
shouldForwardProp: omittedProps(['isObjMultiClusterEnabled']),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catchπŸ‘€

@hana-akamai hana-akamai added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Sep 25, 2024
@coliu-akamai coliu-akamai merged commit 58b2158 into linode:develop Sep 30, 2024
20 checks passed
Copy link

cypress bot commented Sep 30, 2024

Cloud Manager E2EΒ  Β  Run #6592

Run Properties:Β  status check failedΒ FailedΒ #6592 Β β€’Β  git commit 58b21580de: test: [M3-8446] - Add cypress test for Object Storage gen 2 Access Keys landing ...
Project Cloud Manager E2E
Branch Review develop
Run status status check failedΒ FailedΒ #6592
Run duration 28m 33s
Commit git commit 58b21580de: test: [M3-8446] - Add cypress test for Object Storage gen 2 Access Keys landing ...
Committer Connie Liu
View all properties for this run β†—οΈŽ

Test results
Tests that failedΒ  Failures 2
Tests that were flakyΒ  Flaky 4
Tests that did not run due to a developer annotating a test with .skipΒ  Pending 2
Tests that did not run due to a failure in a mocha hookΒ  Skipped 3
Tests that passedΒ  Passing 404
View all changes introduced in this branch β†—οΈŽ

Tests for review

FailedΒ  linodes/rebuild-linode.spec.ts β€’ 1 failed test

View Output Video

Test Artifacts
rebuild linode > rebuilds a linode from Image Screenshots Video
FailedΒ  images/machine-image-upload.spec.ts β€’ 1 failed test

View Output Video

Test Artifacts
machine image > uploads machine image, mock expired upload event Screenshots Video
FlakinessΒ  linodes/clone-linode.spec.ts β€’ 1 flaky test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video
FlakinessΒ  images/machine-image-upload.spec.ts β€’ 1 flaky test

View Output Video

Test Artifacts
machine image > uploads machine image, mock upload canceled failed event Screenshots Video
FlakinessΒ  placementGroups/delete-placement-groups.spec.ts β€’ 1 flaky test

View Output Video

Test Artifacts
Placement Group deletion > can delete with Linodes assigned when unexpected error show up and retry Screenshots Video
FlakinessΒ  kubernetes/smoke-lke-create.spec.ts β€’ 1 flaky test

View Output Video

Test Artifacts
LKE Create Cluster > Simple Page Check Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Object Storage Gen2 Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants