Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.130.0- staging → master #11095

Merged
merged 69 commits into from
Oct 14, 2024
Merged

Release v1.130.0- staging → master #11095

merged 69 commits into from
Oct 14, 2024

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Oct 14, 2024

Cloud Manager

Added:

  • Default root hostname for TXT records (#11022)
  • Firewalls to search result queries (#11023)
  • Number of Nodes selector for DBaaS GA Resize (#11040)
  • Databases to search result queries (#11059)
  • Notification Menu story in Storybook (#10950)
  • Linode Empty Landing story in Storybook (#11012)

Changed:

  • Allow sorting by amount on billing activity table (#10941)
  • Rename notification tax_id_invalid to tax_id_verifying (#10967)
  • Hide SMTP warning for Linodes and accounts that have SMTP enabled (#10991)
  • Update docs links to use latest techdocs.akamai.com URLs (#11003)
  • Use CodeBlock component in KubeConfigDrawer (#11019)
  • Spell out "Configuration" in the Linodes Configurations table (#11046)
  • Improve ActionMenu styling and accessibility (#10964)

Fixed:

  • Styling for the support ticket details page (#10979)
  • Value selection issue in ImageSelect (#11007)
  • Empty data for Account Maintenance CSVs on the first download attempt (#11025)
  • ActionPanel PrimaryButton data-qa attribute (#11035)
  • Users unable to upgrade Kubernetes version from landing page (#11056)
  • Toasts not consistently dismissible with the 'X' button (#11073)
  • TypeScript performance of DismissibleBanner.tsx (#11075)
  • Spelling and grammar mistakes on image create pages (#11096)

Removed:

  • MacOS/Linux-specific getting_started.sh script (#11021)
  • VPC Details dismissible warning banner (#11050)
  • 512GB plan selection from DBaaS (#11036)

Tech Stories:

  • Introduce TanStack Router (#10997)
  • Add support ticket mocks to MSW 2.0 (#10937)
  • Add Pendo to Cloud Manager (#10982)
  • Get dependencies in a more healthy state (#11005)
  • Update Github Actions actions (#11009)
  • Clean up unused assets & icons (#11011)
  • Fix last path-to-regexp dependabot alert (#11015)
  • Add CodeBlock story (#11019)
  • Complete Linode Create refactor:
    • Remove Linode Create v1 - Part 2 (#11020)
    • Rename Linode Create v2 to Linode Create (#11043)
  • Validate redirect and login URLs via URL constructor (#11031)
  • Upgrade upload-artifact and download-artifact actions from v3 to v4 (#11033)
  • Update Sentry to the latest v7 version (#11054)
  • Remove unnecessary isVLAN code from codebase (#11065)
  • Fix TypeScript Performance of BarPercent.tsx (#11076)
  • Improve Pendo URL sanitization (#11079)

Tests:

  • Add integration tests for CloudPulse dashboard (#10891)
  • Add integration test for Object Storage Gen 2 Access Keys page (#10984)
  • Add Cypress integration test for OBJ Gen 2 bucket details tab changes (#10994)
  • Add integration test for Object Storage Gen 2 Properties tab (#11002)
  • Add unit tests for CollapsibleTable and CollapsibleRow components (#11016)
  • Add unit tests for CheckoutSummary component (#11061)
  • Add Cypress test for OBJ Gen 2 create validation & API errors (#11066)

Upcoming Features:

  • Add Region filtering to Linodes landing table (#10639)
  • Add useAclpPreference hook to improve flickering in widget component (#10853)
  • Restrict Image Upload to regions with Object Storage (#11038)
  • Add OBJ Gen2 resource links and fix test flake for bucket creation (#11047)
  • Add DBaaS GA enhancements to backups tab and make Beta fixes (#11048)
  • Add additionalFilters key in CloudPulseWidgetRenderer (#11053)
  • Add Action Menu column to the Databases Table and update Database Logo (#11039)

API-v4

Added:

  • SMTP Enabled account & Linode capabilities (#10991)
  • allow_list to the DatabaseInstance (#11039)

Changed:

  • Rename notification tax_id_invalid to tax_id_verifying (#10967)
  • Firewall attributes created_dt to created and updated_dt to updated (#11023)
  • Databases types to have UpdateDatabasePayload include cluster_size and export the Engines type (#11040)
  • Specify DBaaS fork restore payload and return types (#11048)

Removed:

  • edge type reference in LinodeTypeClass and RegionSite (#10639)

Upcoming Features:

  • Add export to FilterValue interface (#10853)

Validation

Changed:

  • Update validation schema to account for clearing value in ImageSelect (#11007)

UI

Added:

  • new @linode/ui package with BetaChip as the first component (#11057)

bnussman-akamai and others added 30 commits September 26, 2024 14:38
* update actions

* add changeset

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…L` (#11008)

* fix: [M3-8424] - Fix CodeQL alerts for `DOM text reinterpreted as HTML`

* Add changeset

* Remove unnecessary code generated by Copilot
* fix: [M3-8588] - Fix value selection issue in ImageSelect

* Add changeset

* Update packages/manager/.changeset/pr-11007-fixed-1727295720802.md

Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>

* Update validation schema to account for clearing the value in ImageSelect

* Add changeset for validation pacakage

* Update CreateLinodeDiskFromImageSchema based on PR feedback

---------

Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>
## Description 📝
Add Linode Empty Landing story under `Features/Entity Landing Page/Placeholders/Entities`

## How to test 🧪
### Verification steps
(How to verify changes)
- Pull this PR and run Storybook locally, navigate to `Features/Entity Landing Page/Placeholders/Entities`
#11005)

* initial fixes

* fix all new type errors

* begin removing resolutions

* more resolutions

* more resolutions

* fix tests

* remove `jackspeak` resolution

* bump

* switch out `ts-node` for `tsx` to fix Cypress pipeline notification not working

* switch out `ts-node` for `tsx` to fix Cypress pipeline notification not working

* Added changeset: Get dependencies in a more healthy state

* fix autocomplete ui bug

* remove `react-test-renderer` because I think it unused

* remove `reselect-tools` because it is unused

* remove more unused dependencies

* fix console error caused by the Primary Nav

* fix stroybook dark mode bug @dwiley-akamai

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
* clean up unused assets

* changeset

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…ew` instead of `serve` (#11015)

* attempt 1

* allow any host

* re-add skip

* re-add skip

* add changeset

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…ys landing page (#10984)

* integration test for access keys landing page

* Added changeset: Add integration test for Object Storage gen 2 Access Keys page

* rename file to match other gen2 test file name

* remove duplicate function
… issue (#10853)

* upcoming: [DI-20360] - Modified user preference logic

* upcoming: [DI-20360] - Modified user preference logic

* upcoming: [DI-20360] - Removed useEffect from widget component

* upcoming: [DI-20360] - Updated request.tsx file

* upcoming: [DI-20360] - remove sensitive information

* upcoming: [DI-20360] - Update preference logic to avoid extra re-renderings

* upcoming: [DI-20360] - Updated preference logic in custom select

* upcoming: [DI-20360] - Metrics api hardcoded url removed

* upcoming: [DI-20360] - Updated jsdocs & removed un-used variable

* upcoming: [DI-20360] - Test cases updated

* upcoming: [DI-20360] - added changeset

* upcoming: [DI-20360] - Removed unused variable

* upcoming: [DI-20360] - Optimized user preferences to avoid passing update function as props

* upcoming: [DI-20360] - Eslint errors resolve

* upcoming: [DI-20360] - Merge conflicts resolved

* upcoming: [DI-20360] - Changes based on review comments

* upcoming: [DI-20360] - Passing default values to components instead of full preference object

* upcoming: [DI-20360] - Upddated widget components to avoid infinite loop

* upcoming: [DI-20360] - Updated review comment suggestions & test cases

* upcoming: [DI-20360] - Updated review comments

* upcoming: [DI-20360] - Test cases updated

* upcoming: [DI-20360] - Modified user preference logic

* upcoming: [DI-20360] - Modified user preference logic

* upcoming: [DI-20360] - Updated request.tsx file

* upcoming: [DI-20360] - remove sensitive information

* upcoming: [DI-20360] - Update preference logic to avoid extra re-renderings

* upcoming: [DI-20360] - Updated preference logic in custom select

* upcoming: [DI-20360] - Optimized user preferences to avoid passing update function as props

* upcoming: [DI-20360] - Changes based on review comments

* upcoming: [DI-20360] - Upddated widget components to avoid infinite loop

* upcoming: [DI-20360] - Updated review comment suggestions & test cases

* upcoming: [DI-20360] - Updated useAclpPreference hook to use ref for preserving the changes without re-rendering

* upcoming: [DI-20360] - Updated compare props logic

* upcoming: [DI-20360] - Test cases updated

* upcoming: [DI-20360] - Updated ESLint issues

* upcoming: [DI-20360] - Updated review comments

* upcoming: [DI-20360] - Test cases updated

* upcoming: [DI-20360] - Updated logic to prevent widget preference to override

* upcoming: [DI-20360] - Separated components into different files

* upcoming: [DI-20360] - updated funcntions with useMemo

* upcoming: [DI-20360] - updated eslint issues

* upcoming: [DI-20360] - Updated widget preferences logic

* upcoming: [DI-20360] - Updated deep equal logic

* Updated aggregate function type

* upcoming: [DI-20360] - Updated global filter test cases

* upcoming: [DI-20360] - Updated eslint issue

* upcoming: [DI-20360] - Removed unnecessary compare functions

---------

Co-authored-by: vmangalr <vmangalr@akamai.com>
* change: [M3-8468] - Improve action menu styling

* Added changeset: Improve ActionMenu styling

* change: [M3-8468] - color change in theme
* move some things around

* continue moving stuff

* continue moving stuff

* old `LinodesCreate` directory is gone

* Added changeset: Remove Linode Create v1 - Part 2

* skip test because of test flake

* remove type for an unused flag

* remove one more unused file

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…erifying` (#10967)

* change: [M3-8607] - Replace  to

* Keeping events, updating notifications

* Added changeset: Renamed notification tax_id_invalid to tax_id_verifying

* @bnussman-akamai review updates

* Added changeset: Renamed notification tax_id_invalid to tax_id_verifying

---------

Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
* fix: [M3-7274] - Update curl-bash with system default /bin/bash

* Added changeset: Updated getting_started.sh curl to use system default /bin/bash

* @bnussman-akamai @jdamore-linode - removed script

---------

Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
* fix action panel console error

* fix data-qa tag and related tests

* Added changeset: ActionPanel PrimaryButton data-qa attribute
…actions to `v4` (#11033)

* Upgrade upload-artifact and download-artifact actions to v4

* Added changeset: Upgrade `upload-artifact` and `download-artifact` actions from v3 to v4

---------

Co-authored-by: Dajahi Wiley <dwiley@linode.com>
* cater to dependabot moods

* Added changeset: Validate redirect and login URLs via URL constructor

* update changelog to be tech story - feedback @hkhalil-akamai
* Added notification menu story

* refactoring

* Updated MSW handlers

* Updated MSW handlers

* Added notification menu story

* refactoring

* Updated MSW handlers

* Updated MSW handlers

* Help with Events Mocking

* Fixed event message in serverHandlers

* Added changeset: Notification Menu story

* Set once to true for events handler

* switched back to old events

* Updated events handler

---------

Co-authored-by: Alban Bailly <abailly@akamai.com>
…sibleRow components (#11016)

* Unit tests for CollapsibleTable components

* Added changeset: Add unit tests for CollapsibleTable and CollapsibleRow components

* Change TableRowEmpty colSpan value from 5 to 4

* Use self-closing tags for empty TableCell
…es (#10994)

* skeleton tests

* test for E0 endpoint

* finish other tests, now time to cleanup

* remove duplication

* update description

* Added changeset: Add cypress integration test for OBJ gen 2 bucket details tab changes

* update test descriptions

* cleanup: use contains instead of find by text

* parameterize tests based on feedback @jdamore-linode

* confirm testing AC and update tests/fix bug
#11025)

* fix: [M3-8391] - Account maintenance CSV download in the first attempt

* Added changeset: Download Account Maintenance CSVs on the first attempt

* fix: [M3-8392] - explanatory comment
* fix: [M3-8630] - Add default root hostname for TXT records

* Update test

* Added changeset: Add default root hostname for TXT records

---------

Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
…d of spreading (#11041)

* fix: [M3-8696] - Explicitly define 'key' prop instead of spreading

* Added changeset: Explicitly define 'key' prop instead of spreading

* Update cs

---------

Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
* Fix dark mode container colors and mobile avatar padding

* Added changeset: Styling for the support ticket details page

* use a less random value for paddingRight

* Address feedback: better styling fix using margin
…ns table (#11046)

* change: [M3-6994] - Spell out "Configuration" on Linodes Configurations table

* Add changeset
* rename linode create directory from `LinodeCreatev2` to `LinodeCreate`

* rename `Linode Createv 2` to `Linode Create` in the codebase

* Added changeset: Rename `Linode Create v2` to `Linode Create`

* fix last rename

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
* Initial commit: proof of concept

* Route Updates and types

* NBs & Domains

* testing + utils

* better util types

* testing existing routes (wip)

* more testing before more routes

* save progress

* save progress

* save progress

* type improvements

* make basic account routing work

* Revert "make basic account routing work"

This reverts commit 28511f5.

* event routes

* firewalls

* databases

* update maincontent v2

* betas

* VPCs

* Cloud pulse and cleanup

* Rename MainContentV2 to Router

* update vpc routes to use reccomended lazy routing

* support and volumes lazy imports

* post rebase yarn

* lazy imports/exports stackscripts, volumes, profile

* lazy imports/exports placement groups

* lazy imports/exports obj + nb

* lazy imports/exports managed

* lazy imports/exports longview and linodes

* lazy imports/exports images and k8

* lazy imports/exports events & firewalls

* lazy imports/exports remaining

* some cleanup

* More cleanup

* more account routes

* missing domains and linodes routes

* missing longview routes

* missing routes

* wrap up missing routes

* light cleanup

* rename stylesheet

* Added changeset: Introduce TanStack Router

* feedback @bnussman-akamai

* feedback @jaalah-akamai

* post rebase fix

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
@mjac0bs mjac0bs added the Release Cloud Manager releases label Oct 14, 2024
@mjac0bs mjac0bs self-assigned this Oct 14, 2024
@mjac0bs mjac0bs requested review from a team as code owners October 14, 2024 17:02
@mjac0bs mjac0bs requested review from cliu-akamai, carrillo-erik and coliu-akamai and removed request for a team October 14, 2024 17:02
Copy link

github-actions bot commented Oct 14, 2024

Coverage Report:
Base Coverage: 86.98%
Current Coverage: 86.96%

bnussman and others added 2 commits October 14, 2024 13:33
…imum-spelling-mistake

fix: Image Uploader spelling mistake
Copy link

cypress bot commented Oct 14, 2024

Cloud Manager E2E    Run #6671

Run Properties:  status check failed Failed #6671  •  git commit 018f3964ef: Merge pull request #11095 from linode/staging
Project Cloud Manager E2E
Run status status check failed Failed #6671
Run duration 30m 48s
Commit git commit 018f3964ef: Merge pull request #11095 from linode/staging
Committer Mariah Jacobs
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 6
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 429

Tests for review

Failed  linodes/rebuild-linode.spec.ts • 1 failed test

View Output Video

Test Artifacts
rebuild linode > cannot rebuild a provisioning linode Screenshots Video
Failed  placementGroups/delete-placement-groups.spec.ts • 1 failed test

View Output Video

Test Artifacts
Placement Group deletion > can delete with Linodes assigned when unexpected error show up and retry Screenshots Video
Flakiness  linodes/clone-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video
Flakiness  linodes/rebuild-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
rebuild linode > rebuilds a linode from Image Screenshots Video
Flakiness  linodes/linode-storage.spec.ts • 1 flaky test

View Output Video

Test Artifacts
linode storage tab > try to delete in use disk Screenshots Video
Flakiness  objectStorage/object-storage.e2e.spec.ts • 1 flaky test

View Output Video

Test Artifacts
object storage end-to-end tests > can upload, access, and delete objects Screenshots Video
Flakiness  account/service-transfer.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Account service transfers > can initiate and cancel a service transfer Screenshots Video

The first 5 flaky specs are shown, see all 6 specs in Cypress Cloud.

@mjac0bs
Copy link
Contributor Author

mjac0bs commented Oct 14, 2024

The failed or flaky tests in this CI runs are already known to be flaky. Here are some notes from Joe last week:

delete-placement-groups.spec.ts: (all tests)
Cypress tests get tripped up because something is triggering a React re-render when Cypress attempts to click on a button inside the Placement Group deletion modal. Has increased in flakiness recently, but no indication this is a user-facing issue.

clone-linode.spec.ts: can clone a Linode from Linode details page
Known flaky test. Believed to be caused by an API bug (ARB-5515). Test failure message indicates that an expected toast notification failed to appear.

rebuild-linode.spec.ts: cannot rebuild a provisioning linode
Test flaw. Cypress tries to select an image by typing its name and hitting enter, but sometimes operates so quickly that the /images request hasn’t resolved yet. As a result, no Image gets selected and the test fails when Cypress tries to submit the form.

resize-linode.spec.ts was not noted last week as a particularly flaky, but I confirmed that this doesn't appear to be user-facing and resizing a linode is possible in the UI.

This looks ready to merge.

@mjac0bs mjac0bs merged commit 018f396 into master Oct 14, 2024
46 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Cloud Manager releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.