-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-8052] - Toasts are not consistently dismissible with the 'X' button #11073
fix: [M3-8052] - Toasts are not consistently dismissible with the 'X' button #11073
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pmakode-akamai, this does seem to fix the issue based on what I tested, though past places we encountered this issue weren't always reproducible for me.
The repro steps in the PR description were still reproducible, though, and I verified the volume scheduled for creation issue has been fixed.
prod | this branch |
---|---|
bug-volumes.mov |
bugfix-volumes.mov |
A persistent toast is also dismissible, but I wasn't seeing any issue in prod with dismissing after a failed Image Creation (disk_imagize
) event following the repro steps here. That was odd because it was the most recent bug report of this issue affecting someone last Friday. It is also working as expected on this branch.
persistent-toast-can-be-dismissed.mov
Cloud Manager E2E Run #6654
Run Properties:
|
Project |
Cloud Manager E2E
|
Run status |
Failed #6654
|
Run duration | 28m 20s |
Commit |
9dfa675e84: fix: [M3-8052] - Toasts are not consistently dismissible with the 'X' button (#1...
|
Committer | Purvesh Makode |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
2
|
Flaky |
1
|
Pending |
2
|
Skipped |
0
|
Passing |
428
|
Tests for review
linodes/rebuild-linode.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
rebuild linode > cannot rebuild a provisioning linode |
Screenshots
Video
|
placementGroups/delete-placement-groups.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
Placement Group deletion > can delete with Linodes assigned when unexpected error show up and retry |
Screenshots
Video
|
cypress/e2e/core/linodes/linode-config.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
Linode Config management > End-to-End > Clones a config |
Screenshots
Video
|
Description 📝
The close ('X') button on toast notifications is not dismissing the toast in some cases. While most toasts dismiss after 5 seconds so this is not very noticeable, it could pose a problem for any toasts that we do persist (e.g. error toasts) because the toast will be stuck on the page (until refresh).
Changes 🔄
notistackRef
and invokingcloseSnackbar
method directly within the action prop.Target release date 🗓️
N/A
How to test 🧪
Reproduction steps
Verification steps
As an Author I have considered 🤔
Check all that apply