Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [M3-7014] - Remove isVLAN code #11065

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

carrillo-erik
Copy link
Contributor

Description 📝

Removes all redundant isVLAN logic from the codebase.

Changes 🔄

List any change relevant to the reviewer.

  • All instances of isVLAN are removed.
  • Removed VLAN IP table column since the isVLAN prop will not exit anymore.

Target release date 🗓️

10/14/2024

Preview 📷

There are no changes to preview since the direction for this offering shifted. This PR simply removes logic that was left behind.

How to test 🧪

Verification steps

(How to verify changes)

  • Verify that there are no visual regressions in the LinodesLanding table.
  • Verify that all isVLAN logic is removed from the codebase.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@carrillo-erik carrillo-erik self-assigned this Oct 8, 2024
@carrillo-erik carrillo-erik requested a review from a team as a code owner October 8, 2024 13:08
@carrillo-erik carrillo-erik requested review from dwiley-akamai and coliu-akamai and removed request for a team October 8, 2024 13:08
Copy link

github-actions bot commented Oct 8, 2024

Coverage Report:
Base Coverage: 86.95%
Current Coverage: 86.95%

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No visual regressions observed on Linodes landing page ✅
isVLAN logic removed from the codebase ✅

@carrillo-erik carrillo-erik merged commit 7a2e989 into linode:develop Oct 9, 2024
20 checks passed
Copy link

cypress bot commented Oct 9, 2024

Cloud Manager E2E    Run #6645

Run Properties:  status check passed Passed #6645  •  git commit 7a2e98904b: chore: [M3-7014] - Remove `isVLAN` code (#11065)
Project Cloud Manager E2E
Run status status check passed Passed #6645
Run duration 26m 01s
Commit git commit 7a2e98904b: chore: [M3-7014] - Remove `isVLAN` code (#11065)
Committer carrillo-erik
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 430

hasyed-akamai pushed a commit to hasyed-akamai/manager that referenced this pull request Oct 9, 2024
* chore: [M3-7014] - Remove isVLAN code

* Add changset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants