chore: [M3-8524] - Attempt to get dependencies in a more healthy state #11005

bnussman-akamai · 2024-09-25T17:49:21Z

Description 📝

This PR does rm yarn.lock && yarn to re-generate our lockfile 📄
- This will result in dependencies with ~version “Approximately equivalent to version” and ^version “Compatible with version” updating 📦
- This should help us out on the dependabot front. It will also allow us to remove many of our resolutions 🗑️
Resolves the following Dependabot alerts 🤖
Removes resolutions for the following (they are no longer needed)
- braces
- @babel/traverse
- minimist
- yargs-parser
- kind-of
- ua-parser-js
- immer
- glob-parent
- hosted-git-info (upgrading concurrently allowed this one)
- word-wrap
- tough-cookie
- jackspeak (we added this in refactor: [M3-7585] - Upgrade to React 18 #10169 as a hacky fix. Now it is no longer needed 🎉 )
Removes unused dependencies
- react-test-renderer
- reselect-tools
- eslint-plugin-ramda (removed from api-v4 and validation's package.json because they don't use ramda)
- @types/jsdom (We do depend on jsdom but we don't need the types for it because our TypeScript code never imports it)
- eslint-plugin-node (this plugin is not referenced in our eslint config)
- eslint-plugin-storybook (this plugin is not referenced in our eslint config)

Side Effects

I had to fix some issues that TypeScript caught
- This happened because our yarn.lock was re-generated, causing our our TypeScript version to upgrade to the latest minor version. The latest version of TypeScript got smarter and caught a few things!
Had to do something hacky in our Vite configs. I think it is due to Yarn v1's hoisting behavior because the same issue does not happen with pnpm. Shouldn't be a big deal / blocker at all, we'll just want to clean it up later
ts-node (used by our cypress pipeline) stopped working so I just replaced ts-node with a better alternative called tsx
A UI bug with the Autocomplete was introduced and fixed

How to test 🧪

Prerequisites

Checkout this PR
Run yarn for good measure
- Verify yarn.lock does not change when you do this

Things to check

Verify everything works like normal locally (Vite dev server, Storybook, etc...) 💻
Verify Github Actions pass ✅
Verify Baker jobs pass ✅
Look at the resolutions that are removed 👀
- Run yarn why [package name here] and verify the version reported by yarn is not vulnerable (verify the version is equal to or newer than what the resolution was) 📦
Look at the dependabot alerts and verify this PR installs versions that will resolve the alerts
- Use yarn why [package name here] and verify our repo uses version that is patched and not vulnerable (the depenedabot page will tell you what versions are acceptable)

As an Author I have considered 🤔

…tate

bnussman-akamai · 2024-09-25T19:11:56Z

...anager/src/features/Linodes/LinodesDetail/LinodeResize/LinodeResizeUnifiedMigrationPanel.tsx

@@ -112,7 +112,7 @@ export const UnifiedMigrationPanel = (props: Props) => {
              }
              status="help"
              tooltipPosition="right"
-              width={[theme.breakpoints.up('sm')] ? 450 : 300}


We had a handful of things like this. We would get a type error saying [theme.breakpoints.up('sm')] is always truthy so I just updated the code to just use 450

github-actions · 2024-09-25T19:14:56Z

Coverage Report: ✅
Base Coverage: 86.98%
Current Coverage: 86.98%

…ot working

bnussman-akamai · 2024-09-25T21:11:43Z

packages/manager/package.json

@@ -208,7 +208,7 @@
    "simple-git": "^3.19.0",
    "storybook": "^8.3.0",
    "storybook-dark-mode": "^4.0.1",
-    "ts-node": "^10.9.2",
+    "tsx": "^4.19.1",


ts-node was causing our cypress helper scripts issues. I found tsx. It fixes the issue and appears to be a better / more lightweight alternative to ts-node

I know we've also talked about using Bun for these scripts too -- iirc it's only a couple of the scripts in the scripts dir that we use for the Jenkins pipeline that even rely on ts-node, but lately I've been opting to keep that type of stuff in internal repos. I'd be up to move these out of Cloud altogether if it means we can drop the ts-node/tsx dependency

I like the idea of moving scripts like this in internal repos. In the mean time (and because we don't have Bun readily available in CI) I'm totally cool with keeping tsx around. It seems very minimal and useful for us even for things like scripts/package-versions/index.js (if we were to make it .ts)

Eventually, I'd love Bun to be our go-to tool for running this stuff, but we should probably get that setup in CI and formalized before we commit to that

bnussman-akamai · 2024-09-25T22:22:43Z

packages/manager/src/foundations/themes/light.ts

@@ -336,7 +336,6 @@ export const lightTheme: ThemeOptions = {
          svg: {
            color: Color.Neutrals[40],
          },
-          top: 'unset',


For whatever reason, this PR's changes introduced this UI bug.

Removing this line from the theme fixes it.

abailly-akamai

This is a thing of beauty - thx for tackling this important update

things do appear to be at parity and it's great to be able to trust our tests.

one thing i did notice is new console warnings (PrimaryNav simingly)

I did not notice any others so far but i'll keep looking

dwiley-akamai

CM, dev server, and all checks look good ✅

I'm seeing this when I attempt to run Storybook:

Screenshot

bnussman-akamai · 2024-09-26T23:07:21Z

packages/manager/package.json

    "serve": "^14.0.1",
    "simple-git": "^3.19.0",
    "storybook": "^8.3.0",
-    "storybook-dark-mode": "^4.0.1",
-    "ts-node": "^10.9.2",
+    "storybook-dark-mode": "4.0.1",


I pinned this to 4.0.1 because of hipstersmoothie/storybook-dark-mode#282

This will fix the issue @dwiley-akamai caught with Storybook. We'll just need to keep an eye out for storybook-dark-mode to provide a fix before we upgrade storybook-dark-mode next

dwiley-akamai

Storybook looks good now as well 🚀

cypress · 2024-09-27T17:52:58Z

Cloud Manager E2E Run #6585

Run Properties: Passed #6585 • f006ce89d4: chore: [M3-8524] - Attempt to get dependencies in a more healthy state (#11005)

Project	`Cloud Manager E2E`
Branch Review	`develop`
Run status	`Passed #6585`
Run duration	`24m 35s`
Commit	`f006ce89d4: chore: [M3-8524] - Attempt to get dependencies in a more healthy state (#11005)`
Committer	`Banks Nussman`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`3`
Pending	`2`
Skipped	`0`
Passing	`408`
View all changes introduced in this branch ↗︎

bnussman added 5 commits September 25, 2024 12:53

initial fixes

eb1ce36

fix all new type errors

0c2a3dd

begin removing resolutions

dba5125

more resolutions

97084b8

more resolutions

47d01c9

bnussman-akamai added the Dependencies Pull requests that update a dependency file label Sep 25, 2024

bnussman-akamai self-assigned this Sep 25, 2024

bnussman-akamai requested review from a team as code owners September 25, 2024 17:49

bnussman-akamai requested review from cliu-akamai, dwiley-akamai and abailly-akamai and removed request for a team September 25, 2024 17:49

bnussman added 2 commits September 25, 2024 13:52

Merge branch 'develop' into fix/attempt-to-get-dependencies-in-sane-s…

bf4fc73

…tate

fix tests

3063aa1

bnussman-akamai commented Sep 25, 2024

View reviewed changes

bnussman added 5 commits September 25, 2024 15:24

remove jackspeak resolution

c973748

bump

554dd86

switch out ts-node for tsx to fix Cypress pipeline notification n…

483857f

…ot working

switch out ts-node for tsx to fix Cypress pipeline notification n…

30ae5b1

…ot working

Added changeset: Get dependencies in a more healthy state

d2f70cb

bnussman-akamai commented Sep 25, 2024

View reviewed changes

bnussman-akamai added the Ready for Review label Sep 25, 2024

fix autocomplete ui bug

5d0cd00

bnussman-akamai commented Sep 25, 2024

View reviewed changes

bnussman added 3 commits September 25, 2024 18:27

remove react-test-renderer because I think it unused

c7be943

remove reselect-tools because it is unused

33779d4

remove more unused dependencies

986c94e

bnussman-akamai changed the title ~~chore: Attempt to get dependencies in a more healthy state~~ chore: [M3-8524] - Attempt to get dependencies in a more healthy state Sep 25, 2024

abailly-akamai approved these changes Sep 26, 2024

View reviewed changes

fix console error caused by the Primary Nav

8a37058

bnussman-akamai mentioned this pull request Sep 26, 2024

poc: [M3-8631] - Use pnpm as our package manager #11000

Closed

12 tasks

bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Sep 26, 2024

dwiley-akamai reviewed Sep 26, 2024

View reviewed changes

fix stroybook dark mode bug @dwiley-akamai

196b607

bnussman-akamai commented Sep 26, 2024

View reviewed changes

bnussman-akamai requested review from jdamore-linode and dwiley-akamai September 26, 2024 23:09

dwiley-akamai approved these changes Sep 27, 2024

View reviewed changes

bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 27, 2024

bnussman-akamai merged commit f006ce8 into linode:develop Sep 27, 2024
20 checks passed

bnussman-akamai mentioned this pull request Sep 27, 2024

chore: Fix last path-to-regexp depenabot alert by using vite preview instead of serve #11015

Merged

12 tasks

This was referenced Oct 10, 2024

Release v1.130.0 - release → staging #11087

Merged

Release v1.130.0- staging → master #11095

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: [M3-8524] - Attempt to get dependencies in a more healthy state #11005

chore: [M3-8524] - Attempt to get dependencies in a more healthy state #11005

bnussman-akamai commented Sep 25, 2024 •

edited

Loading

bnussman-akamai Sep 25, 2024

github-actions bot commented Sep 25, 2024 •

edited

Loading

bnussman-akamai Sep 25, 2024 •

edited

Loading

jdamore-linode Sep 26, 2024 •

edited

Loading

bnussman-akamai Sep 26, 2024 •

edited

Loading

bnussman-akamai Sep 25, 2024 •

edited

Loading

abailly-akamai left a comment

dwiley-akamai left a comment

bnussman-akamai Sep 26, 2024

dwiley-akamai left a comment

cypress bot commented Sep 27, 2024

chore: [M3-8524] - Attempt to get dependencies in a more healthy state #11005

chore: [M3-8524] - Attempt to get dependencies in a more healthy state #11005

Conversation

bnussman-akamai commented Sep 25, 2024 • edited Loading

Description 📝

Side Effects

How to test 🧪

Prerequisites

Things to check

As an Author I have considered 🤔

bnussman-akamai Sep 25, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 25, 2024 • edited Loading

bnussman-akamai Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

jdamore-linode Sep 26, 2024 • edited Loading

Choose a reason for hiding this comment

bnussman-akamai Sep 26, 2024 • edited Loading

Choose a reason for hiding this comment

bnussman-akamai Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

abailly-akamai left a comment

Choose a reason for hiding this comment

dwiley-akamai left a comment

Choose a reason for hiding this comment

bnussman-akamai Sep 26, 2024

Choose a reason for hiding this comment

dwiley-akamai left a comment

Choose a reason for hiding this comment

cypress bot commented Sep 27, 2024

Cloud Manager E2E Run #6585

bnussman-akamai commented Sep 25, 2024 •

edited

Loading

github-actions bot commented Sep 25, 2024 •

edited

Loading

bnussman-akamai Sep 25, 2024 •

edited

Loading

jdamore-linode Sep 26, 2024 •

edited

Loading

bnussman-akamai Sep 26, 2024 •

edited

Loading

bnussman-akamai Sep 25, 2024 •

edited

Loading