test: [M3-8447] - Add cypress integration test for OBJ gen 2 Bucket Details Properties tab #11002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tails tab changes
|
branched off of m3-8440 for this, so will plan to merge this after that one. Note that there are basically double the changes on this pr as a result (for now) 😅 should be set now! |
coliu-akamai
requested review from
jdamore-linode,
bnussman-akamai and
cpathipa
and removed request for
a team
coliu-akamai
commented
Oct 1, 2024
packages/manager/cypress/e2e/core/objectStorageGen2/bucket-details-gen2.spec.ts
Show resolved
Hide resolved
coliu-akamai
commented
Oct 1, 2024
| @@ -125,7 +125,8 @@ export const createSubnetSchema = object().shape( | |||
| { | |||
| label: labelValidation.required(LABEL_REQUIRED), | |||
| ipv4: string().when('ipv6', { | |||
| is: (value: unknown) => value === '' || value === null || value === undefined, | |||
| is: (value: unknown) => | |||
There was a problem hiding this comment.
?? (hmm lemme see when this file got into the mix)
edit - seems like it happened during a merge - since this is just eslint changes, I'll keep this file as is
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Oct 3, 2024
cpathipa
approved these changes
Oct 7, 2024
Cloud Manager E2E
|
||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Run status |
|
| Run duration | 26m 11s |
| Commit |
|
| Committer | Connie Liu |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
429
|
hasyed-akamai
pushed a commit
to hasyed-akamai/manager
that referenced
this pull request
Oct 9, 2024
…etails Properties tab (linode#11002) * skeleton tests * test for E0 endpoint * finish other tests, now time to cleanup * remove duplication * update description * Added changeset: Add cypress integration test for OBJ gen 2 bucket details tab changes * update test descriptions * rearranging some things * skeleton tests * need to cleanup * cleanup: use contains instead of find by text * why are the create tests also running without the .only?? * update abstraction * parameterize tests based on feedback @jdamore-linode * confirm testing AC and update tests/fix bug * updated tests based on confirmed AC * remove .only * utils file * changeset + add comment * update comment
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Integration test to confirm the Properties tab for obj gen2
Changes 🔄
checkRateLimitsTableto utils file?Target release date 🗓️
10/16+
Preview 📷
As an Author I have considered 🤔
Check all that apply