refactor: [M3-8640] – Move Theme layer from manager package to ui package

[dwiley-akamai]

Description 📝

Move the Theme layer to the recently-created (#11057) linode/ui package.

Target release date 🗓️

10/28/24

How to test 🧪

Ensure that you have no issues building and running the app locally and that CM looks good visually. CI checks should also pass.

As an Author I have considered 🤔

• 👀 Doing a self review
• ❔ Our contribution guidelines
• 🤏 Splitting feature into small PRs
• ➕ Adding a changeset
• 🧪 Providing/Improving test coverage
• 🔐 Removing all sensitive information from the code and PR description
• 🚩 Using a feature flag to protect the release
• 👣 Providing comprehensive reproduction steps
• 📑 Providing or updating our documentation
• 🕛 Scheduling a pair reviewing session
• 📱 Providing mobile support
• ♿ Providing accessibility support

[jaalah-akamai]

✅ Theme is looking good for light/dark
✅ Imports from @linode/ui appear to be referencing exports properly

[bnussman-akamai]

Hmm. The component test pipeline it failing

[dwiley-akamai]

Hmm. The component test pipeline it failing

Yeah, based on the logs this is the issue:

Error: The following dependencies are imported but could not be resolved:

  @linode/ui (imported by /home/node/app/packages/manager/src/utilities/theme.ts)

Are they installed?

Looking into what's causing it but nothing firm yet

[github-actions]

Coverage Report: ✅
Base Coverage: 86.96%
Current Coverage: 86.96%

[bnussman-akamai]

Ah, nice find. This didn't even occur to me

[cypress]

Cloud Manager E2E    Run #6677

Run Properties:   Failed #6677  •  f6f5e97bc2: refactor: [M3-8640] – Move Theme layer from `manager` package to `ui` package (#...

Project	Cloud Manager E2E
Run status	Failed #6677
Run duration	28m 35s
Commit	f6f5e97bc2: refactor: [M3-8640] – Move Theme layer from `manager` package to `ui` package (#...
Committer	Dajahi Wiley
View all properties for this run ↗︎

---

Test results
Failures	2
Flaky	6
Pending	2
Skipped	0
Passing	433

---

Tests for review

  oneClickApps/one-click-apps.spec.ts • 1 failed test

View Output Video

Test		Artifacts
OneClick Apps (OCA) > Lists all the OneClick Apps		Screenshots Video

  helpAndSupport/open-support-ticket.spec.ts • 1 failed test

View Output Video

Test		Artifacts
open support tickets > can create an SMTP support ticket		Screenshots Video

  linodes/switch-linode-state.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
switch linode state > reboots a linode from landing page		Screenshots Video

  objectStorageGen2/bucket-create-gen2.spec.ts • 3 flaky tests

View Output Video

Test		Artifacts
Object Storage Gen2 create bucket tests > can create a bucket with E0 endpoint type		Screenshots Video
Object Storage Gen2 create bucket tests > can create a bucket with E2 endpoint type		Screenshots Video
Object Storage Gen2 create bucket tests > can create a bucket with E3 endpoint type		Screenshots Video

  placementGroups/delete-placement-groups.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
Placement Group deletion > can delete with Linodes assigned when unexpected error show up and retry		Screenshots Video

  volumes/delete-volume.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
volume delete flow > deletes a volume		Screenshots Video