Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: [M3-8746] – Move inputMaxWidth into Theme #11116

Merged
merged 2 commits into from
Oct 21, 2024
Merged

refactor: [M3-8746] – Move inputMaxWidth into Theme #11116

merged 2 commits into from
Oct 21, 2024

Conversation

dwiley-akamai
Copy link
Contributor

Description 📝

Follow-up to #11092 -- move inputMaxWidth into Theme so we can reference it as theme.inputMaxWidth as opposed to exporting & importing the inputMaxWidth variable

Changes 🔄

  • Add inputMaxWidth to Theme
  • Replace uses of inputMaxWidth variable in components with theme.inputMaxWidth

Target release date 🗓️

10/28/24

How to test 🧪

Verification steps

Confirm there are no width regressions for the VPC and Security sections in the Linode Create flow

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@dwiley-akamai dwiley-akamai self-assigned this Oct 16, 2024
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner October 16, 2024 21:31
@dwiley-akamai dwiley-akamai requested review from bnussman-akamai and coliu-akamai and removed request for a team October 16, 2024 21:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

Coverage Report: ✅
Base Coverage: 87.06%
Current Coverage: 87.06%

coliu-akamai
coliu-akamai approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed no VPC width regressions
✅ confirmed no Security width regressions in the skeleton

Thanks Dajahi! Would we need a changeset for the manager package?

@coliu-akamai coliu-akamai added the Add'tl Approval Needed Waiting on another approval! label Oct 17, 2024
@dwiley-akamai
Copy link
Contributor Author

Would we need a changeset for the manager package?

I would say no, having one for the linode/ui package is sufficient since it's just removing an import on the manager side. I can add one if there's disagreement though

bnussman-akamai
bnussman-akamai approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

It feels a bit weird to me to have inputMaxWidth as a token/theme value on the theme in general but I don't think it's necessarily a bad thing.

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 21, 2024
@dwiley-akamai dwiley-akamai merged commit 26d7ea3 into linode:develop Oct 21, 2024
22 of 23 checks passed
@dwiley-akamai dwiley-akamai deleted the M3-8746-inputmaxwidth-in-theme branch October 21, 2024 21:00
@cypress Cypress
Copy link

cypress bot commented Oct 21, 2024

Cloud Manager E2E    Run #6707

Run Properties:  status check passed Passed #6707  •  git commit 26d7ea345f: refactor: [M3-8746] – Move `inputMaxWidth` into `Theme` (#11116)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6707
Run duration 25m 00s
Commit git commit 26d7ea345f: refactor: [M3-8746] – Move `inputMaxWidth` into `Theme` (#11116)
Committer Dajahi Wiley
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 438
View all changes introduced in this branch ↗︎

This was referenced Oct 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coliu-akamai coliu-akamai coliu-akamai approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

Assignees

@dwiley-akamai dwiley-akamai

Labels
Approved Multiple approvals and ready to merge! Modularization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dwiley-akamai @bnussman-akamai @coliu-akamai @DevDW