Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upcoming: [M3-8755] - Add global font and spacing tokens to theme and refactor design tokens #11171

Merged
merged 4 commits into from
Oct 29, 2024
Merged

upcoming: [M3-8755] - Add global font and spacing tokens to theme and refactor design tokens #11171

merged 4 commits into from
Oct 29, 2024

Conversation

pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Oct 28, 2024 •
edited
Loading

Description 📝

Add global font and spacing tokens to theme and refactor Design Tokens

Changes 🔄

  • Added font and spacing tokens to theme
  • Refactor design tokens:
    • Changed theme.* to theme.tokens.*, which are now accessible to components via theme.tokens.*
    • Refactor chart and interaction tokens

Target release date 🗓️

N/A

Preview 📷

No visual changes.

How to test 🧪

  • Ensure everything builds properly
  • Ensure no visual changes
  • Verify these global tokens are accessible to components via theme.tokens.*
  • Ensure no tokens with <name>Tokens naming conventions are being used in the codebase

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@pmakode-akamai pmakode-akamai added the Design Tokens Laying the groundwork for Design Tokens label Oct 28, 2024
@pmakode-akamai pmakode-akamai self-assigned this Oct 28, 2024
@pmakode-akamai pmakode-akamai marked this pull request as ready for review October 28, 2024 12:36
@pmakode-akamai pmakode-akamai requested a review from a team as a code owner October 28, 2024 12:36
@pmakode-akamai pmakode-akamai requested review from carrillo-erik and cpathipa and removed request for a team October 28, 2024 12:36
@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Oct 28, 2024
@mjac0bs mjac0bs mentioned this pull request Oct 28, 2024
Merged
12 tasks
@jaalah-akamai
Copy link
Contributor

jaalah-akamai commented Oct 28, 2024 •
edited
Loading

@pmakode-akamai Let's work to move these to a theme.tokens.* structure as opposed to <name>Tokens naming convention.

See #11138 (review)

@pmakode-akamai pmakode-akamai force-pushed the M3-8755-add-global-fontTokens-and-spacingTokens-to-theme branch from fa6745f to a9542b5 Compare October 29, 2024 06:12
@pmakode-akamai pmakode-akamai changed the title upcoming: [M3-8755] - Add global fontTokens and spacingTokens to theme upcoming: [M3-8755] - Add global font and spacing tokens to theme and refactor design tokens Oct 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

Coverage Report: ✅
Base Coverage: 87.04%
Current Coverage: 87.04%

@pmakode-akamai pmakode-akamai removed the Add'tl Approval Needed Waiting on another approval! label Oct 29, 2024
@pmakode-akamai pmakode-akamai added the Add'tl Approval Needed Waiting on another approval! label Oct 29, 2024
@cpathipa cpathipa added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! Ready for Review labels Oct 29, 2024
@pmakode-akamai pmakode-akamai merged commit edf9438 into linode:develop Oct 29, 2024
23 checks passed
@cypress Cypress
Copy link

cypress bot commented Oct 29, 2024

Cloud Manager E2E    Run #6748

Run Properties:  status check passed Passed #6748  •  git commit edf94388c4: upcoming: [M3-8755] - Add global `font` and `spacing` tokens to theme and refact...
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6748
Run duration 27m 02s
Commit git commit edf94388c4: upcoming: [M3-8755] - Add global `font` and `spacing` tokens to theme and refact...
Committer Purvesh Makode
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 445
View all changes introduced in this branch ↗︎

@jaalah-akamai jaalah-akamai mentioned this pull request Nov 7, 2024
Merged
@hana-akamai hana-akamai mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpathipa cpathipa cpathipa approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@carrillo-erik carrillo-erik Awaiting requested review from carrillo-erik carrillo-erik is a code owner automatically assigned from linode/frontend

@jaalah-akamai jaalah-akamai Awaiting requested review from jaalah-akamai

@mjac0bs mjac0bs Awaiting requested review from mjac0bs

Assignees

@pmakode-akamai pmakode-akamai

Labels
Approved Multiple approvals and ready to merge! Design Tokens Laying the groundwork for Design Tokens
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmakode-akamai @jaalah-akamai @bnussman-akamai @cpathipa